Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1694)

Unified Diff: base/test/BUILD.gn

Issue 2143253002: Convert test_support source sets to static libs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Android Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/BUILD.gn ('k') | chrome/app/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/BUILD.gn
diff --git a/base/test/BUILD.gn b/base/test/BUILD.gn
index 0283c67fec1ecfe2d9319ca264c117f8e50df4e7..7e2c4ac6e71c580f12da45aeca31022da1ae0454 100644
--- a/base/test/BUILD.gn
+++ b/base/test/BUILD.gn
@@ -9,7 +9,7 @@ if (is_android) {
import("//build/config/android/rules.gni")
}
-source_set("test_config") {
+static_library("test_config") {
testonly = true
sources = [
"test_switches.cc",
@@ -23,7 +23,7 @@ source_set("test_config") {
}
# GYP: //base/base.gyp:test_support_base
-source_set("test_support") {
+static_library("test_support") {
testonly = true
sources = [
"gtest_util.cc",
@@ -216,6 +216,9 @@ config("perf_test_config") {
defines = [ "PERF_TEST" ]
}
+# This is a source set instead of a static library because it seems like some
+# linkers get confused when "main" is in a static library, and if you link to
+# this, you always want the object file anyway.
source_set("test_support_perf") {
testonly = true
sources = [
@@ -230,7 +233,7 @@ source_set("test_support_perf") {
public_configs = [ ":perf_test_config" ]
}
-source_set("test_launcher_nacl_nonsfi") {
+static_library("test_launcher_nacl_nonsfi") {
testonly = true
sources = [
"launcher/test_launcher_nacl_nonsfi.cc",
@@ -241,7 +244,7 @@ source_set("test_launcher_nacl_nonsfi") {
]
}
-source_set("run_all_unittests") {
+static_library("run_all_unittests") {
testonly = true
sources = [
"run_all_unittests.cc",
« no previous file with comments | « ash/BUILD.gn ('k') | chrome/app/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698