Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2143253002: Convert test_support source sets to static libs (Closed)

Created:
4 years, 5 months ago by brettw
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, sadrul, asvitkine+watch_chromium.org, zea+watch_chromium.org, johnme+watch_chromium.org, browser-components-watch_chromium.org, dougsteed+watch_chromium.org, sheretov+watch_chromium.org, ryanchung+watch_chromium.org, msw+watch_chromium.org, jam, vadimgo+watch_chromium.org, Peter Beverloo, darin-cc_chromium.org, sync-reviews_chromium.org, vabr+watchlistautofill_chromium.org, kalyank, mlamouri+watch-content_chromium.org, rouslan+autofill_chromium.org, media-router+watch_chromium.org, hcarmona+bubble_chromium.org, rouslan+bubble_chromium.org, groby+bubble_chromium.org, feature-media-reviews_chromium.org, jdonnelly+autofillwatch_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert test_support source sets to static libs This changes about 1/4 of the targets in the build with the name "test_support" in the name to be static libraries instead of source sets. Also changes related source sets to static libraries in the same files when such a change looked possible. Also puts //components/drive:test_support_chromeos in a chromeos conditional since this target is chromeos specific). BUG=627637 Committed: https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9 Cr-Commit-Position: refs/heads/master@{#405312}

Patch Set 1 #

Patch Set 2 : leveldb #

Patch Set 3 : Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -67 lines) Patch
M ash/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M base/test/BUILD.gn View 1 2 5 chunks +7 lines, -4 lines 0 comments Download
M chrome/app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/media/router/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/content/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/bubble/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/captive_portal/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/cast_certificate/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/component_updater/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/drive/BUILD.gn View 3 chunks +25 lines, -23 lines 0 comments Download
M components/gcm_driver/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/gcm_driver/crypto/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/gcm_driver/instance_id/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/guest_view/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/leveldb_proto/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/BUILD.gn View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 26 (16 generated)
brettw
4 years, 5 months ago (2016-07-12 21:47:37 UTC) #3
Wez
nit: Is there a BUG= we can add to provide context for this change? :)
4 years, 5 months ago (2016-07-12 21:59:50 UTC) #6
brettw
leveldb
4 years, 5 months ago (2016-07-12 22:56:45 UTC) #11
brettw
Bug added.
4 years, 5 months ago (2016-07-12 22:57:45 UTC) #13
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-13 00:32:31 UTC) #17
brettw
Android
4 years, 5 months ago (2016-07-13 19:45:21 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143253002/40001
4 years, 5 months ago (2016-07-13 19:46:29 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-13 22:40:23 UTC) #23
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 22:41:15 UTC) #24
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 22:43:38 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9
Cr-Commit-Position: refs/heads/master@{#405312}

Powered by Google App Engine
This is Rietveld 408576698