src/IceInstMIPS32.h - Issue 2143243003: SubZero: Correct parenthesis for mem operands with labels in MIPS32

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstMIPS32.h

Issue 2143243003: SubZero: Correct parenthesis for mem operands with labels in MIPS32 (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstMIPS32.h

diff --git a/src/IceInstMIPS32.h b/src/IceInstMIPS32.h

index ec0760d5fe61f140ab94b6a4aa37783368b8d9d3..fe3a2a20d2fad882032c9f4974ef049eaf50580f 100644

--- a/src/IceInstMIPS32.h

+++ b/src/IceInstMIPS32.h

@@ -517,9 +517,7 @@ public:

getSrc(0)->emit(Func);

Str << ", ";

emitRelocOp(Str, Reloc);

- Str << (Reloc ? "(" : "");

getSrc(1)->emit(Func);

- Str << (Reloc ? ")" : "");

}

void emitIAS(const Cfg *Func) const override {

« no previous file with comments | « no previous file | src/IceInstMIPS32.cpp » ('j') | no next file with comments »