Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2143243003: SubZero: Correct parenthesis for mem operands with labels in MIPS32 (Closed)

Created:
4 years, 5 months ago by mohit.bhakkad
Modified:
4 years, 5 months ago
Reviewers:
srdjan.obucina, Eric Holk, Karl, Jim Stichnoth, John
CC:
native-client-reviews_googlegroups.com, jaydeep.patil, rich.fuhler_imgtec.com, sagar.thakur
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/IceInstMIPS32.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/IceInstMIPS32.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
mohit.bhakkad
4 years, 5 months ago (2016-07-13 12:49:16 UTC) #3
Jim Stichnoth
lgtm
4 years, 5 months ago (2016-07-13 14:30:52 UTC) #4
Jim Stichnoth
4 years, 5 months ago (2016-07-13 14:32:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6a661ced2dc95a67ca228fb417438e8800ec66d1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698