Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2143183004: Use SkImage::makeNonTextureImage to perform GPU->CPU readback in skcanvas_video_renderer. (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
Reviewers:
DaleCurtis, reed1
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org, reed1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SkImage::makeNonTextureImage to perform GPU->CPU readback in skcanvas_video_renderer. Remove the last use case of texture-backed SkBitmaps in Chroimum. Committed: https://crrev.com/99d59c53eed88f715584273334ea90abc503681c Cr-Commit-Position: refs/heads/master@{#405233}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -16 lines) Patch
M media/renderers/skcanvas_video_renderer.cc View 1 chunk +9 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
bsalomon
This is functionally identical but allows Skia to drop a misfeature we've been trying to ...
4 years, 5 months ago (2016-07-13 17:37:53 UTC) #2
DaleCurtis
lgtm
4 years, 5 months ago (2016-07-13 17:40:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143183004/1
4 years, 5 months ago (2016-07-13 17:41:32 UTC) #5
reed1
4 years, 5 months ago (2016-07-13 17:43:39 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 19:46:36 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 19:47:27 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 19:50:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99d59c53eed88f715584273334ea90abc503681c
Cr-Commit-Position: refs/heads/master@{#405233}

Powered by Google App Engine
This is Rietveld 408576698