Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2143183003: Revert of DevTools: rename initialUrl to url in the Browser.createTarget protocol method. (Closed)

Created:
4 years, 5 months ago by pfeldman
Modified:
4 years, 5 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: rename initialUrl to url in the Browser.createTarget protocol method. (patchset #3 id:40001 of https://codereview.chromium.org/2140533003/ ) Reason for revert: Broke a test. Original issue's description: > DevTools: rename initialUrl to url in the Browser.createTarget protocol method, fix chrome embedder handler. > > TBR=alexclarke > NOTRY=true > NOPRESUBMIT=true > > Committed: https://crrev.com/d3814a729f29e99cbdcbd470d2520cacb5ec4e53 > Cr-Commit-Position: refs/heads/master@{#404839} TBR=paulirish@chromium.org,alexclarke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/038c6b81465f9dcb17b83a4d9f20f4d8b6884fd5 Cr-Commit-Position: refs/heads/master@{#404843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M components/devtools_discovery/devtools_discovery_manager.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/devtools/protocol/browser_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/browser_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
pfeldman
Created Revert of DevTools: rename initialUrl to url in the Browser.createTarget protocol method.
4 years, 5 months ago (2016-07-12 22:10:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143183003/1
4 years, 5 months ago (2016-07-12 22:13:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 22:15:55 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 22:16:24 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 22:17:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/038c6b81465f9dcb17b83a4d9f20f4d8b6884fd5
Cr-Commit-Position: refs/heads/master@{#404843}

Powered by Google App Engine
This is Rietveld 408576698