Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Issue 2143163002: [turbofan] Loop peeling with explicit loop exits. (Closed)

Created:
4 years, 5 months ago by Jarin
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Michael Hablich, Michael Starzinger
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Loop peeling with explicit loop exits. Committed: https://crrev.com/54a0389309daf070cbd31c4f92e742a609c317ed Cr-Commit-Position: refs/heads/master@{#37791}

Patch Set 1 #

Patch Set 2 : Better unittests #

Patch Set 3 : Attempt to make win happy #

Patch Set 4 : Fix, move peeling later. #

Patch Set 5 : Rebase #

Patch Set 6 : Tweak #

Patch Set 7 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -209 lines) Patch
M src/compiler/loop-analysis.h View 3 chunks +15 lines, -6 lines 0 comments Download
M src/compiler/loop-analysis.cc View 1 2 3 4 11 chunks +88 lines, -31 lines 0 comments Download
M src/compiler/loop-peeling.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/loop-peeling.cc View 1 2 3 4 4 chunks +90 lines, -88 lines 0 comments Download
M src/compiler/pipeline.cc View 1 2 3 4 2 chunks +23 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/loop-peeling-unittest.cc View 1 2 3 4 5 6 19 chunks +107 lines, -81 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Jarin
Here is a preview. To make this landable, I'd like to add some mjsunit tests ...
4 years, 5 months ago (2016-07-12 21:23:11 UTC) #2
Jarin
Could you take a look, please? In a subsequent CL, I will stage the peeling ...
4 years, 5 months ago (2016-07-14 20:07:09 UTC) #7
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-07-15 09:40:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143163002/120001
4 years, 5 months ago (2016-07-15 10:21:04 UTC) #10
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 5 months ago (2016-07-15 10:23:38 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 10:24:37 UTC) #13
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/54a0389309daf070cbd31c4f92e742a609c317ed
Cr-Commit-Position: refs/heads/master@{#37791}

Powered by Google App Engine
This is Rietveld 408576698