Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2143153002: Don't track allocations in product mode. (Closed)

Created:
4 years, 5 months ago by rmacnak
Modified:
4 years, 5 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : other archs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -81 lines) Patch
M runtime/vm/assembler_arm.cc View 1 2 3 chunks +13 lines, -11 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 1 2 2 chunks +18 lines, -16 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 1 2 2 chunks +21 lines, -19 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/class_table.h View 1 6 chunks +11 lines, -8 lines 0 comments Download
M runtime/vm/class_table.cc View 14 chunks +24 lines, -19 lines 0 comments Download
M runtime/vm/gc_marker.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/heap.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/heap_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 4 chunks +10 lines, -0 lines 0 comments Download
M runtime/vm/scavenger.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rmacnak
4 years, 5 months ago (2016-07-12 20:08:43 UTC) #2
Florian Schneider
https://codereview.chromium.org/2143153002/diff/20001/runtime/vm/assembler_x64.cc File runtime/vm/assembler_x64.cc (right): https://codereview.chromium.org/2143153002/diff/20001/runtime/vm/assembler_x64.cc#newcode3324 runtime/vm/assembler_x64.cc:3324: #ifndef PRODUCT What about the other platforms?
4 years, 5 months ago (2016-07-12 20:13:41 UTC) #3
rmacnak
https://codereview.chromium.org/2143153002/diff/20001/runtime/vm/assembler_x64.cc File runtime/vm/assembler_x64.cc (right): https://codereview.chromium.org/2143153002/diff/20001/runtime/vm/assembler_x64.cc#newcode3324 runtime/vm/assembler_x64.cc:3324: #ifndef PRODUCT On 2016/07/12 20:13:41, Florian Schneider wrote: > ...
4 years, 5 months ago (2016-07-12 21:00:40 UTC) #4
Florian Schneider
lgtm
4 years, 5 months ago (2016-07-12 21:03:14 UTC) #5
rmacnak
4 years, 5 months ago (2016-07-12 21:15:12 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
a6f954b0f31c73b1293132c3b1e97d31b7ba72cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698