Don't inherit block style if text is inserted after paragraph selection.

Don't inherit block style if text is inserted after paragraph selection.

It is reported that, under some condition, an unexpected <div> is inserted
when text is inserted after a paragraph is selected. This was caused by
InsertText::doApply() adjusting the text style according to the current typing
style after the insertion.

This patch clears block properties from the typing style if the selection ends
at the start of a block.

Additionally, this patch fixes another issue in DeleteSelectionCommand, which
may erroneously insert a placeholder <br> if the return value of
VisiblePosition::previous() or next() is a null VisiblePosition.

BUG=349531
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170157

[yosin_UTC9, 2014-03-27 07:01:05]

LGTM!

TypingStyle is another evil in FrameSelection. It is better to move TypingStyle
into Editor class?

https://codereview.chromium.org/214313002/diff/1/LayoutTests/editing/execComm...
File
LayoutTests/editing/execCommand/insert-text-not-inheriting-block-properties.html
(right):

https://codereview.chromium.org/214313002/diff/1/LayoutTests/editing/execComm...
LayoutTests/editing/execCommand/insert-text-not-inheriting-block-properties.html:41:
range.setStart(container.firstChild.firstChild, 0); // First <span>.
nit: You can use Selection.collapse(parentNode, offset)

https://codereview.chromium.org/214313002/diff/1/Source/core/editing/DeleteSe...
File Source/core/editing/DeleteSelectionCommand.cpp (right):

https://codereview.chromium.org/214313002/diff/1/Source/core/editing/DeleteSe...
Source/core/editing/DeleteSelectionCommand.cpp:378: if (node == m_startBlock) {
Fantastic! I remembered I struggled this part.

[Yuta Kitamura, 2014-03-27 07:12:35]

https://codereview.chromium.org/214313002/diff/1/LayoutTests/editing/execComm...
File
LayoutTests/editing/execCommand/insert-text-not-inheriting-block-properties.html
(right):

https://codereview.chromium.org/214313002/diff/1/LayoutTests/editing/execComm...
LayoutTests/editing/execCommand/insert-text-not-inheriting-block-properties.html:41:
range.setStart(container.firstChild.firstChild, 0); // First <span>.
On 2014/03/27 07:01:05, Yoshi wrote:
> nit: You can use Selection.collapse(parentNode, offset)

That's much better, thanks. Fixed.

[Yuta Kitamura, 2014-03-27 07:12:38]

The CQ bit was checked by yutak@chromium.org

[commit-bot: I haz the power, 2014-03-27 07:12:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yutak@chromium.org/214313002/20001

[commit-bot: I haz the power, 2014-03-27 07:22:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 07:22:21]

Try jobs failed on following builders:
  tryserver.blink on win_blink_compile_dbg

[Yuta Kitamura, 2014-03-27 07:28:32]

The CQ bit was checked by yutak@chromium.org

[commit-bot: I haz the power, 2014-03-27 07:28:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yutak@chromium.org/214313002/20001

[commit-bot: I haz the power, 2014-03-27 08:19:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 08:19:05]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[Yuta Kitamura, 2014-03-27 08:55:05]

The CQ bit was checked by yutak@chromium.org

[commit-bot: I haz the power, 2014-03-27 08:55:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yutak@chromium.org/214313002/20001

[commit-bot: I haz the power, 2014-03-27 08:59:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 08:59:07]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[Yuta Kitamura, 2014-03-27 09:00:47]

The CQ bit was checked by yutak@chromium.org

[commit-bot: I haz the power, 2014-03-27 09:00:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yutak@chromium.org/214313002/20001

[commit-bot: I haz the power, 2014-03-27 09:59:55]

Change committed as 170157