third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py - Issue 2143123004: Access environment variables through Host object instead of directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

Issue 2143123004: Access environment variables through Host object instead of directly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased and updated after change for dummy home dir on linux. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

index d01217095fafe55b7842be09c50d8b7091a519e0..0810b1b3241fcb6b89d1a4fefca75c2ee6dd83d9 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

@@ -473,11 +473,11 @@ def _set_up_derived_options(port, options, args):

options.batch_size = port.default_batch_size()

if not options.child_processes:

- options.child_processes = os.environ.get("WEBKIT_TEST_CHILD_PROCESSES",

- str(port.default_child_processes()))

+ options.child_processes = port.host.environ.get("WEBKIT_TEST_CHILD_PROCESSES",

+ str(port.default_child_processes()))

if not options.max_locked_shards:

- options.max_locked_shards = int(os.environ.get("WEBKIT_TEST_MAX_LOCKED_SHARDS",

- str(port.default_max_locked_shards())))

+ options.max_locked_shards = int(port.host.environ.get("WEBKIT_TEST_MAX_LOCKED_SHARDS",

+ str(port.default_max_locked_shards())))

if not options.configuration:

options.configuration = port.default_configuration()