third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py - Issue 2143123004: Access environment variables through Host object instead of directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py

Issue 2143123004: Access environment variables through Host object instead of directly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased and updated after change for dummy home dir on linux. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py

index 0a0c741f45c490de5dc2c24ff99f974b95f91275..e71c174ecf6386dc62b0afa637d2cec5c099a634 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py

@@ -161,7 +161,7 @@ class WinPort(base.Port):

# FIXME: This is a temporary hack to get the cr-win bot online until

# someone from the cr-win port can take a look.

apache_envvars = ['SYSTEMDRIVE', 'SYSTEMROOT', 'TEMP', 'TMP']

- for key, value in os.environ.items():

+ for key, value in self.host.environ.copy().items():

if key not in env and key in apache_envvars:

env[key] = value