Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py

Issue 2143123004: Access environment variables through Host object instead of directly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased and updated after change for dummy home dir on linux. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py
index e96347d3d39d0bb81ba9a4671612d2c04e59afd0..43d9e325ea109fb50e49ad0c8a9264b5dbc96f5a 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py
@@ -70,7 +70,7 @@ class DumpReaderWin(DumpReader):
def _find_depot_tools_path(self):
"""Attempt to find depot_tools location in PATH."""
- for i in os.environ['PATH'].split(os.pathsep):
+ for i in self._host.environ.get('PATH').split(os.pathsep):
if os.path.isfile(os.path.join(i, 'gclient')):
return i
@@ -92,10 +92,10 @@ class DumpReaderWin(DumpReader):
]
program_files_directories = ['C:\\Program Files']
- program_files = os.environ.get('ProgramFiles')
+ program_files = self._host.environ.get('ProgramFiles')
if program_files:
program_files_directories.append(program_files)
- program_files = os.environ.get('ProgramFiles(x86)')
+ program_files = self._host.environ.get('ProgramFiles(x86)')
if program_files:
program_files_directories.append(program_files)
@@ -104,7 +104,7 @@ class DumpReaderWin(DumpReader):
for program_files in program_files_directories:
possible_cdb_locations.append(template % program_files)
- gyp_defines = os.environ.get('GYP_DEFINES', [])
+ gyp_defines = self._host.environ.get('GYP_DEFINES', [])
if gyp_defines:
gyp_defines = shlex.split(gyp_defines)
if 'windows_sdk_path' in gyp_defines:

Powered by Google App Engine
This is Rietveld 408576698