Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Issue 2143113003: [DevTools] Set skip_in_browser=true for synthethic keyboard events. (Closed)

Created:
4 years, 5 months ago by dgozman
Modified:
4 years, 5 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Set skip_in_browser=true for synthethic keyboard events. We don't have native event (which is used in browser) and we only intend these events to be processed by web contents anyway. BUG=627221 Committed: https://crrev.com/204daf38980716774d1d1e960ff803e6d317665e Cr-Commit-Position: refs/heads/master@{#404984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/input_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Tests.js View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
dgozman
Could you please take a look?
4 years, 5 months ago (2016-07-12 18:41:59 UTC) #2
caseq
lgtm
4 years, 5 months ago (2016-07-12 19:03:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143113003/1
4 years, 5 months ago (2016-07-12 21:40:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/166643)
4 years, 5 months ago (2016-07-12 23:07:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143113003/1
4 years, 5 months ago (2016-07-13 00:16:37 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191867)
4 years, 5 months ago (2016-07-13 01:08:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143113003/1
4 years, 5 months ago (2016-07-13 01:19:43 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 03:51:17 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 03:51:28 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 03:54:36 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/204daf38980716774d1d1e960ff803e6d317665e
Cr-Commit-Position: refs/heads/master@{#404984}

Powered by Google App Engine
This is Rietveld 408576698