Add icons for palette.

Add icons for palette.

These icons are used in https://codereview.chromium.org/2147783002/ and https://codereview.chromium.org/2148573002/.

BUG=625251

[jdufault, 2016-07-12 23:57:12]

Description was changed from

==========
Add icons for palette.

BUG=625251
==========

to

==========
Add icons for palette.

These icons are used in https://codereview.chromium.org/2147783002/ and
https://codereview.chromium.org/2148573002/.

BUG=625251
==========

[jdufault, 2016-07-13 18:16:09]

jdufault@chromium.org changed reviewers:
+ estade@chromium.org, tdanderson@chromium.org

[jdufault, 2016-07-13 18:16:31]

estade@, PTAL. Thanks!

+tdanderson@ for FYI.

[Evan Stade, 2016-07-13 18:22:38]

palette on its own doesn't seem like a sufficiently unique or descriptive name
for this feature

https://codereview.chromium.org/2143073003/diff/20001/ui/gfx/vector_icons/pal...
File ui/gfx/vector_icons/palette_capture_screen.icon (right):

https://codereview.chromium.org/2143073003/diff/20001/ui/gfx/vector_icons/pal...
ui/gfx/vector_icons/palette_capture_screen.icon:5: CANVAS_DIMENSIONS, 30,
the canvas dimensions for the general icon should always be twice the 1x version

[jdufault, 2016-07-20 23:23:11]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 23:23:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2016-07-20 23:24:05]

Going with palette name after offline discussion.

https://codereview.chromium.org/2143073003/diff/20001/ui/gfx/vector_icons/pal...
File ui/gfx/vector_icons/palette_capture_screen.icon (right):

https://codereview.chromium.org/2143073003/diff/20001/ui/gfx/vector_icons/pal...
ui/gfx/vector_icons/palette_capture_screen.icon:5: CANVAS_DIMENSIONS, 30,
On 2016/07/13 18:22:37, Evan Stade wrote:
> the canvas dimensions for the general icon should always be twice the 1x
version

The assets should all be properly scaled now.

[jdufault, 2016-07-20 23:25:31]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 23:25:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 00:07:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 00:07:24]

Dry run: This issue passed the CQ dry run.

[jdufault, 2016-07-21 23:40:07]

Ping

[Evan Stade, 2016-07-22 01:26:44]

oops, sorry. I still think it would be nice to combine this change with the
change that actually makes use of the icons.

https://codereview.chromium.org/2143073003/diff/80001/ui/gfx/vector_icons/pal...
File ui/gfx/vector_icons/palette_action_capture_region.icon (right):

https://codereview.chromium.org/2143073003/diff/80001/ui/gfx/vector_icons/pal...
ui/gfx/vector_icons/palette_action_capture_region.icon:1: CANVAS_DIMENSIONS, 40,
you need license headers

https://codereview.chromium.org/2143073003/diff/80001/ui/gfx/vector_icons_sou...
File ui/gfx/vector_icons_sources.gypi (right):

https://codereview.chromium.org/2143073003/diff/80001/ui/gfx/vector_icons_sou...
ui/gfx/vector_icons_sources.gypi:111:
'vector_icons/palette_action_capture_region.1x.icon',
+tdanderson these will need to be made ash specific

[tdanderson, 2016-07-22 17:31:10]

On 2016/07/22 01:26:44, Evan Stade wrote:
> oops, sorry. I still think it would be nice to combine this change with the
> change that actually makes use of the icons.
> 
>
https://codereview.chromium.org/2143073003/diff/80001/ui/gfx/vector_icons/pal...
> File ui/gfx/vector_icons/palette_action_capture_region.icon (right):
> 
>
https://codereview.chromium.org/2143073003/diff/80001/ui/gfx/vector_icons/pal...
> ui/gfx/vector_icons/palette_action_capture_region.icon:1: CANVAS_DIMENSIONS,
40,
> you need license headers
> 
>
https://codereview.chromium.org/2143073003/diff/80001/ui/gfx/vector_icons_sou...
> File ui/gfx/vector_icons_sources.gypi (right):
> 
>
https://codereview.chromium.org/2143073003/diff/80001/ui/gfx/vector_icons_sou...
> ui/gfx/vector_icons_sources.gypi:111:
> 'vector_icons/palette_action_capture_region.1x.icon',
> +tdanderson these will need to be made ash specific

Acknowledged - I will take care of doing that.

[jdufault, 2016-07-22 17:38:41]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 17:39:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2016-07-22 17:40:09]

> oops, sorry. I still think it would be nice to combine this change with the
> change that actually makes use of the icons.

I'd like to keep them separate, since the usage CL is already pretty large and
not having the icons makes it a bit easier to review.

https://codereview.chromium.org/2143073003/diff/80001/ui/gfx/vector_icons/pal...
File ui/gfx/vector_icons/palette_action_capture_region.icon (right):

https://codereview.chromium.org/2143073003/diff/80001/ui/gfx/vector_icons/pal...
ui/gfx/vector_icons/palette_action_capture_region.icon:1: CANVAS_DIMENSIONS, 40,
On 2016/07/22 01:26:43, Evan Stade wrote:
> you need license headers

Done.

[commit-bot: I haz the power, 2016-07-22 19:28:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 19:28:23]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-07-22 22:05:50]

On 2016/07/22 17:40:09, jdufault wrote:
> > oops, sorry. I still think it would be nice to combine this change with the
> > change that actually makes use of the icons.
> 
> I'd like to keep them separate, since the usage CL is already pretty large and
> not having the icons makes it a bit easier to review.

how so? Sure, in general larger CLs are harder to review but I'd measure "large"
in terms of inter-depedent code. It's easy to compartmentalize your review to
just .cc files, for example, so the added .icons would not really impact the
over reviewability.

> 
>
https://codereview.chromium.org/2143073003/diff/80001/ui/gfx/vector_icons/pal...
> File ui/gfx/vector_icons/palette_action_capture_region.icon (right):
> 
>
https://codereview.chromium.org/2143073003/diff/80001/ui/gfx/vector_icons/pal...
> ui/gfx/vector_icons/palette_action_capture_region.icon:1: CANVAS_DIMENSIONS,
40,
> On 2016/07/22 01:26:43, Evan Stade wrote:
> > you need license headers
> 
> Done.

[jdufault, 2016-07-22 22:36:35]

On 2016/07/22 22:05:50, Evan Stade wrote:
> On 2016/07/22 17:40:09, jdufault wrote:
> > > oops, sorry. I still think it would be nice to combine this change with
the
> > > change that actually makes use of the icons.
> > 
> > I'd like to keep them separate, since the usage CL is already pretty large
and
> > not having the icons makes it a bit easier to review.
> 
> how so? Sure, in general larger CLs are harder to review but I'd measure
"large"
> in terms of inter-depedent code. It's easy to compartmentalize your review to
> just .cc files, for example, so the added .icons would not really impact the
> over reviewability.

I prefer to see only what I strictly need to when reviewing a CL. Regardless,
I've cherry picked this commit into the CL where it is first used and added you
as a reviewer. I'll close out this CL.

[jdufault, 2016-07-22 22:37:15]

On 2016/07/22 22:36:35, jdufault wrote:
> On 2016/07/22 22:05:50, Evan Stade wrote:
> > On 2016/07/22 17:40:09, jdufault wrote:
> > > > oops, sorry. I still think it would be nice to combine this change with
> the
> > > > change that actually makes use of the icons.
> > > 
> > > I'd like to keep them separate, since the usage CL is already pretty large
> and
> > > not having the icons makes it a bit easier to review.
> > 
> > how so? Sure, in general larger CLs are harder to review but I'd measure
> "large"
> > in terms of inter-depedent code. It's easy to compartmentalize your review
to
> > just .cc files, for example, so the added .icons would not really impact the
> > over reviewability.
> 
> I prefer to see only what I strictly need to when reviewing a CL. Regardless,
> I've cherry picked this commit into the CL where it is first used and added
you
> as a reviewer. I'll close out this CL.

That other CL is https://codereview.chromium.org/2148573002/.