Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: chrome/renderer/plugins/power_saver_info.cc

Issue 2143073002: Plugin Power Saver: Improve blocked tiny plugins behavior (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rename a variable again Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/plugins/power_saver_info.h ('k') | chrome/renderer/resources/plugins/blocked_plugin.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/plugins/power_saver_info.cc
diff --git a/chrome/renderer/plugins/power_saver_info.cc b/chrome/renderer/plugins/power_saver_info.cc
index 9de969413e01e0163426ef0eed95d2ff93794a0e..6209b64138461f08bcad526f65f1642b100f47dc 100644
--- a/chrome/renderer/plugins/power_saver_info.cc
+++ b/chrome/renderer/plugins/power_saver_info.cc
@@ -71,9 +71,7 @@ std::string GetPluginInstancePosterAttribute(
} // namespace
PowerSaverInfo::PowerSaverInfo()
- : is_eligible(false),
- power_saver_enabled(false),
- blocked_for_background_tab(false) {}
+ : power_saver_enabled(false), blocked_for_background_tab(false) {}
PowerSaverInfo::PowerSaverInfo(const PowerSaverInfo& other) = default;
@@ -92,10 +90,10 @@ PowerSaverInfo PowerSaverInfo::Get(content::RenderFrame* render_frame,
plugin_info.name == base::ASCIIToUTF16(content::kFlashPluginName);
PowerSaverInfo info;
- info.is_eligible = power_saver_setting_on &&
+ bool is_eligible = power_saver_setting_on &&
(is_flash || override_for_testing == "ignore-list");
info.power_saver_enabled = override_for_testing == "always" ||
- (power_saver_setting_on && info.is_eligible);
+ (power_saver_setting_on && is_eligible);
if (info.power_saver_enabled) {
// Even if we disable PPS in the next block because content is same-origin,
« no previous file with comments | « chrome/renderer/plugins/power_saver_info.h ('k') | chrome/renderer/resources/plugins/blocked_plugin.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698