Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2143053004: Revert of [DevTools] Allow modifying instrumenting agents while iterating. (Closed)

Created:
4 years, 5 months ago by dgozman
Modified:
4 years, 5 months ago
Reviewers:
caseq, jam
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Allow modifying instrumenting agents while iterating. (patchset #4 id:60001 of https://codereview.chromium.org/2139443002/ ) Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=627577 Original issue's description: > [DevTools] Allow modifying instrumenting agents while iterating. > > In this case we stop iteration early (possibly loosing instrumentation call though). > > This can happen if during instrumentation call we paused the execution, entered > nested message loop and detached from there (thus removing agent from the list). > > BUG=none > > Committed: https://crrev.com/a0206e7e8481b0bd171beb9fc895bd55201eff6e > Cr-Commit-Position: refs/heads/master@{#404694} TBR=caseq@chromium.org NOTRY=true BUG=627373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -105 lines) Patch
D third_party/WebKit/LayoutTests/inspector-protocol/debugger/detach-when-paused-in-instrumentation.html View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/debugger/detach-when-paused-in-instrumentation-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py View 4 chunks +3 lines, -69 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
dgozman
Created Revert of [DevTools] Allow modifying instrumenting agents while iterating.
4 years, 5 months ago (2016-07-12 20:43:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143053004/1
4 years, 5 months ago (2016-07-12 20:45:28 UTC) #3
jam
adding NOTRY=true since this is breaking everything.
4 years, 5 months ago (2016-07-12 22:45:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143053004/1
4 years, 5 months ago (2016-07-12 22:48:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143053004/1
4 years, 5 months ago (2016-07-12 22:57:01 UTC) #12
jam
4 years, 5 months ago (2016-07-12 23:01:24 UTC) #13
(manually reverting)

Powered by Google App Engine
This is Rietveld 408576698