Transfer components of SurfaceId in OffscreenCanvas

Transfer components of SurfaceId in OffscreenCanvas

OffscreenCanvas should keep the SurfaceId from its associated HTMLCanvasElement
so that when it is transferred to worker thread, it can directly submit
CompositorFrame to browser without going through main thread.

This is a preparation step before submiting CompositorFrame to Surface from
either main or worker thread.

BUG=611796
Committed: https://crrev.com/1193f1696086ae64d6226225d12e77c3c78a84a6
Cr-Commit-Position: refs/heads/master@{#405673}

[xlai (Olivia), 2016-07-14 20:06:04]

The CQ bit was checked by xlai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 20:07:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xlai (Olivia), 2016-07-14 20:09:08]

Description was changed from

==========
Transfer components of SurfaceId in OffscreenCanvas

OffscreenCanvas should keep the SurfaceId from its associated HTMLCanvasElement
so that when it is transferred to worker thread, it can directly submit
CompositorFrame to browser without going through main thread.

This is a preparation step in establishing a mojo msg channel between
OffscreenCanvas on worker thread and browser, and a preparation step to submit
CompositorFrame to Surface from either main or worker thread.


BUG=611796
==========

to

==========
Transfer components of SurfaceId in OffscreenCanvas

OffscreenCanvas should keep the SurfaceId from its associated HTMLCanvasElement
so that when it is transferred to worker thread, it can directly submit
CompositorFrame to browser without going through main thread.

This is a preparation step before submiting CompositorFrame to Surface from
either main or worker thread.


BUG=611796
==========

[xlai (Olivia), 2016-07-14 20:09:08]

xlai@chromium.org changed reviewers:
+ haraken@chromium.org, xidachen@chromium.org

[xidachen, 2016-07-14 20:19:56]

lgtm with nits. Please wait for haraken@'s approval.

https://codereview.chromium.org/2143033005/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp
(right):

https://codereview.chromium.org/2143033005/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp:373:
doWriteUint32(nonce);
Here you need doWriteUint64 instead of 32.

https://codereview.chromium.org/2143033005/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp:1550: if
(!doReadUint32(&nonce))
doReadUint64 instead of 32 because nounce is uint_64.

https://codereview.chromium.org/2143033005/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h (right):

https://codereview.chromium.org/2143033005/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h:150: void
writeTransferredOffscreenCanvas(uint32_t index, uint32_t width, uint32_t height,
uint32_t id, uint32_t clientId, uint32_t localId, uint64_t nonce);
I know this is not introduced by this CL, but now that we have several Ids,
could you change the variable named "id" to "canvasId", and do that for the
other places too?

[xlai (Olivia), 2016-07-14 20:29:14]

Patchset #3 (id:40001) has been deleted

[xlai (Olivia), 2016-07-14 23:39:18]

haraken@: could you pls review this? thanks!

https://codereview.chromium.org/2143033005/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp
(right):

https://codereview.chromium.org/2143033005/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp:373:
doWriteUint32(nonce);
On 2016/07/14 20:19:55, xidachen wrote:
> Here you need doWriteUint64 instead of 32.

Done.

https://codereview.chromium.org/2143033005/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp:1550: if
(!doReadUint32(&nonce))
On 2016/07/14 20:19:55, xidachen wrote:
> doReadUint64 instead of 32 because nounce is uint_64.

Done.

https://codereview.chromium.org/2143033005/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h (right):

https://codereview.chromium.org/2143033005/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h:150: void
writeTransferredOffscreenCanvas(uint32_t index, uint32_t width, uint32_t height,
uint32_t id, uint32_t clientId, uint32_t localId, uint64_t nonce);
On 2016/07/14 20:19:55, xidachen wrote:
> I know this is not introduced by this CL, but now that we have several Ids,
> could you change the variable named "id" to "canvasId", and do that for the
> other places too?

Done.

[haraken, 2016-07-15 00:05:31]

LGTM

[xlai (Olivia), 2016-07-15 00:45:18]

The CQ bit was checked by xlai@chromium.org

[xlai (Olivia), 2016-07-15 00:45:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
xidachen@chromium.org
Link to the patchset: https://codereview.chromium.org/2143033005/#ps70001
(title: "Fixed unit test")

[commit-bot: I haz the power, 2016-07-15 00:46:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xidachen, 2016-07-15 00:47:00]

The CQ bit was checked by xidachen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 00:47:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xlai (Olivia), 2016-07-15 01:17:22]

The CQ bit was unchecked by xlai@chromium.org

[xlai (Olivia), 2016-07-15 01:17:29]

The CQ bit was checked by xlai@chromium.org

[commit-bot: I haz the power, 2016-07-15 01:18:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 02:04:57]

Description was changed from

==========
Transfer components of SurfaceId in OffscreenCanvas

OffscreenCanvas should keep the SurfaceId from its associated HTMLCanvasElement
so that when it is transferred to worker thread, it can directly submit
CompositorFrame to browser without going through main thread.

This is a preparation step before submiting CompositorFrame to Surface from
either main or worker thread.


BUG=611796
==========

to

==========
Transfer components of SurfaceId in OffscreenCanvas

OffscreenCanvas should keep the SurfaceId from its associated HTMLCanvasElement
so that when it is transferred to worker thread, it can directly submit
CompositorFrame to browser without going through main thread.

This is a preparation step before submiting CompositorFrame to Surface from
either main or worker thread.


BUG=611796
==========

[commit-bot: I haz the power, 2016-07-15 02:04:58]

Committed patchset #4 (id:70001)

[commit-bot: I haz the power, 2016-07-15 02:05:19]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-15 02:07:20]

Description was changed from

==========
Transfer components of SurfaceId in OffscreenCanvas

OffscreenCanvas should keep the SurfaceId from its associated HTMLCanvasElement
so that when it is transferred to worker thread, it can directly submit
CompositorFrame to browser without going through main thread.

This is a preparation step before submiting CompositorFrame to Surface from
either main or worker thread.


BUG=611796
==========

to

==========
Transfer components of SurfaceId in OffscreenCanvas

OffscreenCanvas should keep the SurfaceId from its associated HTMLCanvasElement
so that when it is transferred to worker thread, it can directly submit
CompositorFrame to browser without going through main thread.

This is a preparation step before submiting CompositorFrame to Surface from
either main or worker thread.

BUG=611796

Committed: https://crrev.com/1193f1696086ae64d6226225d12e77c3c78a84a6
Cr-Commit-Position: refs/heads/master@{#405673}
==========

[commit-bot: I haz the power, 2016-07-15 02:07:21]

Patchset 4 (id:??) landed as
https://crrev.com/1193f1696086ae64d6226225d12e77c3c78a84a6
Cr-Commit-Position: refs/heads/master@{#405673}