content/browser/tracing/tracing_controller_browsertest.cc - Issue 2143033004: Change TraceDataEndPoint::ReceiveTraceChunk() to accept unique_ptr<string>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tracing/tracing_controller_browsertest.cc

Issue 2143033004: Change TraceDataEndPoint::ReceiveTraceChunk() to accept unique_ptr<string> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: now use unique_ptr Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/tracing/tracing_controller_browsertest.cc

diff --git a/content/browser/tracing/tracing_controller_browsertest.cc b/content/browser/tracing/tracing_controller_browsertest.cc

index 47d60b595b1fd241d6f833df3370debdb6e2b3b7..b4a2f0d75b49aede8707e340d9026cf44c771d6b 100644

--- a/content/browser/tracing/tracing_controller_browsertest.cc

+++ b/content/browser/tracing/tracing_controller_browsertest.cc

@@ -65,9 +65,9 @@ class TracingControllerTestEndpoint : public TraceDataEndpoint {

base::RefCountedString*)> done_callback)

: done_callback_(done_callback) {}

- void ReceiveTraceChunk(const std::string& chunk) override {

- EXPECT_FALSE(chunk.empty());

- trace_ += chunk;

+ void ReceiveTraceChunk(std::unique_ptr<std::string> chunk) override {

+ EXPECT_FALSE(chunk->empty());

+ trace_ += *chunk;

}

void ReceiveTraceFinalContents(

« no previous file with comments | « no previous file | content/browser/tracing/tracing_controller_impl.h » ('j') | content/browser/tracing/tracing_controller_impl_data_sinks.cc » ('J')