Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2143023002: Issue 26764. Insert required imports in the correct sorting order. (Closed)

Created:
4 years, 5 months ago by scheglov
Modified:
4 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+395 lines, -39 lines) Patch
M pkg/analysis_server/lib/src/services/correction/util.dart View 2 chunks +89 lines, -28 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 8 chunks +8 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/correction/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/services/correction/util_test.dart View 1 chunk +292 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 5 months ago (2016-07-12 15:56:30 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2143023002/diff/1/pkg/analysis_server/test/services/correction/util_test.dart File pkg/analysis_server/test/services/correction/util_test.dart (right): https://codereview.chromium.org/2143023002/diff/1/pkg/analysis_server/test/services/correction/util_test.dart#newcode282 pkg/analysis_server/test/services/correction/util_test.dart:282: class _SourceMock implements Source { We already have ...
4 years, 5 months ago (2016-07-12 16:12:23 UTC) #2
scheglov
4 years, 5 months ago (2016-07-12 18:17:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bf731dfcd5eb1b7623cda68a75b5f9ddb4bcc20e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698