Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2143003006: Remove unit test that tests subsetting texture backed bitmaps. (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove unit test that tests subsetting texture backed bitmaps. BUG=skia:5531 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2143003006 Committed: https://skia.googlesource.com/skia/+/201364cb025d3fdb3fa803f362690804b817d1b8

Patch Set 1 #

Patch Set 2 : Delete more code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -169 lines) Patch
M tests/ReadPixelsTest.cpp View 1 2 chunks +0 lines, -169 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
bsalomon
4 years, 5 months ago (2016-07-14 14:08:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143003006/1
4 years, 5 months ago (2016-07-14 14:09:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/9692)
4 years, 5 months ago (2016-07-14 14:13:19 UTC) #8
reed1
bit by the dreaded unused-function error (cursed be its name) lgtm
4 years, 5 months ago (2016-07-14 14:20:10 UTC) #9
bsalomon
On 2016/07/14 14:20:10, reed1 wrote: > bit by the dreaded unused-function error (cursed be its ...
4 years, 5 months ago (2016-07-14 14:21:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143003006/20001
4 years, 5 months ago (2016-07-14 14:21:30 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 14:43:34 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/201364cb025d3fdb3fa803f362690804b817d1b8

Powered by Google App Engine
This is Rietveld 408576698