|
|
Created:
4 years, 5 months ago by bsalomon Modified:
4 years, 5 months ago Reviewers:
robertphillips, reed1 CC:
reviews_skia.org Base URL:
https://chromium.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionRemove unit test that tests subsetting texture backed bitmaps.
BUG=skia:5531
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2143003006
Committed: https://skia.googlesource.com/skia/+/201364cb025d3fdb3fa803f362690804b817d1b8
Patch Set 1 #Patch Set 2 : Delete more code #
Created: 4 years, 5 months ago
Messages
Total messages: 15 (8 generated)
Description was changed from ========== Remove unit test that tests subsetting texture backed bitmaps. BUG=skia: ========== to ========== Remove unit test that tests subsetting texture backed bitmaps. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2143003006 ==========
bsalomon@google.com changed reviewers: + reed@google.com, robertphillips@google.com
Description was changed from ========== Remove unit test that tests subsetting texture backed bitmaps. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2143003006 ========== to ========== Remove unit test that tests subsetting texture backed bitmaps. BUG=skia:5531 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2143003006 ==========
The CQ bit was checked by bsalomon@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
bit by the dreaded unused-function error (cursed be its name) lgtm
On 2016/07/14 14:20:10, reed1 wrote: > bit by the dreaded unused-function error (cursed be its name) > > lgtm That just means I get to delete even more code! :D
The CQ bit was checked by bsalomon@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com Link to the patchset: https://codereview.chromium.org/2143003006/#ps20001 (title: "Delete more code")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove unit test that tests subsetting texture backed bitmaps. BUG=skia:5531 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2143003006 ========== to ========== Remove unit test that tests subsetting texture backed bitmaps. BUG=skia:5531 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2143003006 Committed: https://skia.googlesource.com/skia/+/201364cb025d3fdb3fa803f362690804b817d1b8 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/201364cb025d3fdb3fa803f362690804b817d1b8 |