Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2562)

Unified Diff: Source/core/rendering/RenderTheme.h

Issue 21430003: Implement interfaces in PaintInfo and make it a class. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@getterPaintInfo01
Patch Set: Second try Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderTheme.h
diff --git a/Source/core/rendering/RenderTheme.h b/Source/core/rendering/RenderTheme.h
index 057b53f3168a95bf1b994ad57f9a46c9ee7ecd6a..e1e4df2d52e264afee6431cef9629be9483da53c 100644
--- a/Source/core/rendering/RenderTheme.h
+++ b/Source/core/rendering/RenderTheme.h
@@ -77,9 +77,9 @@ public:
// This method is called to paint the widget as a background of the RenderObject. A widget's foreground, e.g., the
// text of a button, is always rendered by the engine itself. The boolean return value indicates
// whether the CSS border/background should also be painted.
- bool paint(RenderObject*, const PaintInfo&, const IntRect&);
- bool paintBorderOnly(RenderObject*, const PaintInfo&, const IntRect&);
- bool paintDecorations(RenderObject*, const PaintInfo&, const IntRect&);
+ bool paint(RenderObject*, PaintInfo&, const IntRect&);
+ bool paintBorderOnly(RenderObject*, PaintInfo&, const IntRect&);
+ bool paintDecorations(RenderObject*, PaintInfo&, const IntRect&);
// The remaining methods should be implemented by the platform-specific portion of the theme, e.g.,
// RenderThemeMac.cpp for Mac OS X.
@@ -176,7 +176,7 @@ public:
virtual ScrollbarControlSize scrollbarControlSizeForPart(ControlPart) { return RegularScrollbar; }
// Method for painting the caps lock indicator
- virtual bool paintCapsLockIndicator(RenderObject*, const PaintInfo&, const IntRect&) { return 0; };
+ virtual bool paintCapsLockIndicator(RenderObject*, PaintInfo&, const IntRect&) { return 0; };
// Returns the repeat interval of the animation for the progress bar.
virtual double animationRepeatIntervalForProgressBar(RenderProgress*) const;
@@ -204,7 +204,7 @@ public:
virtual IntSize sliderTickSize() const = 0;
// Returns the distance of slider tick origin from the slider track center.
virtual int sliderTickOffsetFromTrackCenter() const = 0;
- void paintSliderTicks(RenderObject*, const PaintInfo&, const IntRect&);
+ void paintSliderTicks(RenderObject*, PaintInfo&, const IntRect&);
virtual bool shouldShowPlaceholderWhenFocused() const { return false; }
virtual bool shouldHaveSpinButton(HTMLInputElement*) const;
@@ -267,14 +267,14 @@ protected:
virtual bool paintMenuListButton(RenderObject*, const PaintInfo&, const IntRect&) { return true; }
virtual void adjustMeterStyle(RenderStyle*, Element*) const;
- virtual bool paintMeter(RenderObject*, const PaintInfo&, const IntRect&);
+ virtual bool paintMeter(RenderObject*, PaintInfo&, const IntRect&);
virtual void adjustProgressBarStyle(RenderStyle*, Element*) const;
virtual bool paintProgressBar(RenderObject*, const PaintInfo&, const IntRect&) { return true; }
#if ENABLE(INPUT_SPEECH)
virtual void adjustInputFieldSpeechButtonStyle(RenderStyle*, Element*) const;
- virtual bool paintInputFieldSpeechButton(RenderObject*, const PaintInfo&, const IntRect&);
+ virtual bool paintInputFieldSpeechButton(RenderObject*, PaintInfo&, const IntRect&);
#endif
virtual void adjustSliderTrackStyle(RenderStyle*, Element*) const;
@@ -318,11 +318,11 @@ protected:
virtual bool shouldUseFallbackTheme(RenderStyle*) const;
void adjustStyleUsingFallbackTheme(RenderStyle*, Element*);
- bool paintUsingFallbackTheme(RenderObject*, const PaintInfo&, const IntRect&);
+ bool paintUsingFallbackTheme(RenderObject*, PaintInfo&, const IntRect&);
void adjustCheckboxStyleUsingFallbackTheme(RenderStyle*, Element*) const;
- bool paintCheckboxUsingFallbackTheme(RenderObject*, const PaintInfo&, const IntRect&);
+ bool paintCheckboxUsingFallbackTheme(RenderObject*, PaintInfo&, const IntRect&);
void adjustRadioStyleUsingFallbackTheme(RenderStyle*, Element*) const;
- bool paintRadioUsingFallbackTheme(RenderObject*, const PaintInfo&, const IntRect&);
+ bool paintRadioUsingFallbackTheme(RenderObject*, PaintInfo&, const IntRect&);
public:
// Methods for state querying

Powered by Google App Engine
This is Rietveld 408576698