Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/rendering/RenderThemeChromiumMac.h

Issue 21430003: Implement interfaces in PaintInfo and make it a class. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@getterPaintInfo01
Patch Set: Fixed Linux compilation (hopefuly Windows too), addressing some reviewer's suggestions. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/rendering/PaintInfo.h ('K') | « Source/core/rendering/RenderThemeChromiumDefault.cpp ('k') | Source/core/rendering/RenderThemeChromiumMac.mm » ('j') | Source/core/rendering/svg/SVGRenderingContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderThemeChromiumMac.h
diff --git a/Source/core/rendering/RenderThemeChromiumMac.h b/Source/core/rendering/RenderThemeChromiumMac.h
index fbbf684fc3729dc1f503183b00fa07a6031e57f7..f34be95f863b49222ccb611a59170271109c0d62 100644
--- a/Source/core/rendering/RenderThemeChromiumMac.h
+++ b/Source/core/rendering/RenderThemeChromiumMac.h
@@ -73,12 +73,12 @@ public:
virtual int popupInternalPaddingTop(RenderStyle*) const OVERRIDE;
virtual int popupInternalPaddingBottom(RenderStyle*) const OVERRIDE;
- virtual bool paintCapsLockIndicator(RenderObject*, const PaintInfo&, const IntRect&) OVERRIDE;
+ virtual bool paintCapsLockIndicator(RenderObject*, PaintInfo&, const IntRect&) OVERRIDE;
virtual bool popsMenuByArrowKeys() const OVERRIDE { return true; }
virtual IntSize meterSizeForBounds(const RenderMeter*, const IntRect&) const OVERRIDE;
- virtual bool paintMeter(RenderObject*, const PaintInfo&, const IntRect&) OVERRIDE;
+ virtual bool paintMeter(RenderObject*, PaintInfo&, const IntRect&) OVERRIDE;
virtual bool supportsMeter(ControlPart) const OVERRIDE;
// Returns the repeat interval of the animation for the progress bar.
@@ -94,36 +94,36 @@ protected:
virtual bool supportsSelectionForegroundColors() const OVERRIDE { return false; }
- virtual bool paintTextField(RenderObject*, const PaintInfo&, const IntRect&);
+ virtual bool paintTextField(RenderObject*, PaintInfo&, const IntRect&);
virtual void adjustTextFieldStyle(RenderStyle*, Element*) const;
- virtual bool paintTextArea(RenderObject*, const PaintInfo&, const IntRect&);
+ virtual bool paintTextArea(RenderObject*, PaintInfo&, const IntRect&);
virtual void adjustTextAreaStyle(RenderStyle*, Element*) const;
- virtual bool paintMenuList(RenderObject*, const PaintInfo&, const IntRect&);
+ virtual bool paintMenuList(RenderObject*, PaintInfo&, const IntRect&);
virtual void adjustMenuListStyle(RenderStyle*, Element*) const;
- virtual bool paintMenuListButton(RenderObject*, const PaintInfo&, const IntRect&);
+ virtual bool paintMenuListButton(RenderObject*, PaintInfo&, const IntRect&);
virtual void adjustMenuListButtonStyle(RenderStyle*, Element*) const;
virtual void adjustProgressBarStyle(RenderStyle*, Element*) const;
- virtual bool paintProgressBar(RenderObject*, const PaintInfo&, const IntRect&);
+ virtual bool paintProgressBar(RenderObject*, PaintInfo&, const IntRect&);
- virtual bool paintSliderTrack(RenderObject*, const PaintInfo&, const IntRect&);
+ virtual bool paintSliderTrack(RenderObject*, PaintInfo&, const IntRect&);
- virtual bool paintSliderThumb(RenderObject*, const PaintInfo&, const IntRect&);
+ virtual bool paintSliderThumb(RenderObject*, PaintInfo&, const IntRect&);
- virtual bool paintSearchField(RenderObject*, const PaintInfo&, const IntRect&);
+ virtual bool paintSearchField(RenderObject*, PaintInfo&, const IntRect&);
virtual void adjustSearchFieldStyle(RenderStyle*, Element*) const;
virtual void adjustSearchFieldCancelButtonStyle(RenderStyle*, Element*) const;
- virtual bool paintSearchFieldCancelButton(RenderObject*, const PaintInfo&, const IntRect&);
+ virtual bool paintSearchFieldCancelButton(RenderObject*, PaintInfo&, const IntRect&);
virtual void adjustSearchFieldDecorationStyle(RenderStyle*, Element*) const;
- virtual bool paintSearchFieldDecoration(RenderObject*, const PaintInfo&, const IntRect&);
+ virtual bool paintSearchFieldDecoration(RenderObject*, PaintInfo&, const IntRect&);
virtual void adjustSearchFieldResultsDecorationStyle(RenderStyle*, Element*) const;
- virtual bool paintSearchFieldResultsDecoration(RenderObject*, const PaintInfo&, const IntRect&);
+ virtual bool paintSearchFieldResultsDecoration(RenderObject*, PaintInfo&, const IntRect&);
virtual bool supportsClosedCaptioning() const { return true; }
@@ -154,7 +154,7 @@ private:
const IntSize* popupButtonSizes() const;
const int* popupButtonMargins() const;
const int* popupButtonPadding(NSControlSize) const;
- void paintMenuListButtonGradients(RenderObject*, const PaintInfo&, const IntRect&);
+ void paintMenuListButtonGradients(RenderObject*, PaintInfo&, const IntRect&);
const IntSize* menuListSizes() const;
const IntSize* searchFieldSizes() const;
@@ -177,22 +177,22 @@ private:
protected:
virtual void adjustMediaSliderThumbSize(RenderStyle*) const;
- virtual bool paintMediaPlayButton(RenderObject*, const PaintInfo&, const IntRect&);
- virtual bool paintMediaMuteButton(RenderObject*, const PaintInfo&, const IntRect&);
- virtual bool paintMediaSliderTrack(RenderObject*, const PaintInfo&, const IntRect&);
+ virtual bool paintMediaPlayButton(RenderObject*, PaintInfo&, const IntRect&);
+ virtual bool paintMediaMuteButton(RenderObject*, PaintInfo&, const IntRect&);
+ virtual bool paintMediaSliderTrack(RenderObject*, PaintInfo&, const IntRect&);
virtual String extraFullScreenStyleSheet();
- virtual bool paintMediaSliderThumb(RenderObject*, const PaintInfo&, const IntRect&);
- virtual bool paintMediaVolumeSliderContainer(RenderObject*, const PaintInfo&, const IntRect&);
- virtual bool paintMediaVolumeSliderTrack(RenderObject*, const PaintInfo&, const IntRect&);
- virtual bool paintMediaVolumeSliderThumb(RenderObject*, const PaintInfo&, const IntRect&);
+ virtual bool paintMediaSliderThumb(RenderObject*, PaintInfo&, const IntRect&);
+ virtual bool paintMediaVolumeSliderContainer(RenderObject*, PaintInfo&, const IntRect&);
+ virtual bool paintMediaVolumeSliderTrack(RenderObject*, PaintInfo&, const IntRect&);
+ virtual bool paintMediaVolumeSliderThumb(RenderObject*, PaintInfo&, const IntRect&);
virtual bool usesMediaControlStatusDisplay() { return false; }
virtual bool hasOwnDisabledStateHandlingFor(ControlPart) const { return true; }
virtual bool usesVerticalVolumeSlider() const { return false; }
virtual String formatMediaControlsTime(float time) const;
virtual String formatMediaControlsCurrentTime(float currentTime, float duration) const;
- virtual bool paintMediaFullscreenButton(RenderObject*, const PaintInfo&, const IntRect&);
- virtual bool paintMediaToggleClosedCaptionsButton(RenderObject*, const PaintInfo&, const IntRect&);
+ virtual bool paintMediaFullscreenButton(RenderObject*, PaintInfo&, const IntRect&);
+ virtual bool paintMediaToggleClosedCaptionsButton(RenderObject*, PaintInfo&, const IntRect&);
// Controls color values returned from platformFocusRingColor(). systemColor() will be used when false.
bool usesTestModeFocusRingColor() const;
« Source/core/rendering/PaintInfo.h ('K') | « Source/core/rendering/RenderThemeChromiumDefault.cpp ('k') | Source/core/rendering/RenderThemeChromiumMac.mm » ('j') | Source/core/rendering/svg/SVGRenderingContext.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698