Source/core/rendering/RenderThemeChromiumDefault.h - Issue 21430003: Implement interfaces in PaintInfo and make it a class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderThemeChromiumDefault.h

Issue 21430003: Implement interfaces in PaintInfo and make it a class. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@getterPaintInfo01

Patch Set: Fixed Linux compilation (hopefuly Windows too), addressing some reviewer's suggestions. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/PaintInfo.h ('K') | « Source/core/rendering/RenderTheme.cpp ('k') | Source/core/rendering/RenderThemeChromiumDefault.cpp » ('j') | Source/core/rendering/svg/SVGRenderingContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderThemeChromiumDefault.h

diff --git a/Source/core/rendering/RenderThemeChromiumDefault.h b/Source/core/rendering/RenderThemeChromiumDefault.h

index 25423ed28f460e81abf27f9430d0a60f8babe475..2cfe442b5ba5c1e84daf9d51c8fe82e6462fcf62 100644

--- a/Source/core/rendering/RenderThemeChromiumDefault.h

+++ b/Source/core/rendering/RenderThemeChromiumDefault.h

@@ -61,24 +61,24 @@ public:

static void setCaretBlinkInterval(double);

virtual double caretBlinkIntervalInternal() const;

- virtual bool paintCheckbox(RenderObject*, const PaintInfo&, const IntRect&);

+ virtual bool paintCheckbox(RenderObject*, PaintInfo&, const IntRect&);

virtual void setCheckboxSize(RenderStyle*) const;

- virtual bool paintRadio(RenderObject*, const PaintInfo&, const IntRect&);

+ virtual bool paintRadio(RenderObject*, PaintInfo&, const IntRect&);

virtual void setRadioSize(RenderStyle*) const;

- virtual bool paintButton(RenderObject*, const PaintInfo&, const IntRect&);

- virtual bool paintTextField(RenderObject*, const PaintInfo&, const IntRect&);

- virtual bool paintMenuList(RenderObject*, const PaintInfo&, const IntRect&);

- virtual bool paintSliderTrack(RenderObject*, const PaintInfo&, const IntRect&);

- virtual bool paintSliderThumb(RenderObject*, const PaintInfo&, const IntRect&);

+ virtual bool paintButton(RenderObject*, PaintInfo&, const IntRect&);

+ virtual bool paintTextField(RenderObject*, PaintInfo&, const IntRect&);

+ virtual bool paintMenuList(RenderObject*, PaintInfo&, const IntRect&);

+ virtual bool paintSliderTrack(RenderObject*, PaintInfo&, const IntRect&);

+ virtual bool paintSliderThumb(RenderObject*, PaintInfo&, const IntRect&);

virtual void adjustInnerSpinButtonStyle(RenderStyle*, Element*) const;

- virtual bool paintInnerSpinButton(RenderObject*, const PaintInfo&, const IntRect&);

+ virtual bool paintInnerSpinButton(RenderObject*, PaintInfo&, const IntRect&);

virtual bool popsMenuBySpaceOrReturn() const OVERRIDE { return true; }

- virtual bool paintProgressBar(RenderObject*, const PaintInfo&, const IntRect&);

+ virtual bool paintProgressBar(RenderObject*, PaintInfo&, const IntRect&);

virtual bool shouldOpenPickerWithF4Key() const OVERRIDE;