Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Unified Diff: Source/core/rendering/RenderTableSection.cpp

Issue 21430003: Implement interfaces in PaintInfo and make it a class. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@getterPaintInfo01
Patch Set: Fixed Linux compilation (hopefuly Windows too), addressing some reviewer's suggestions. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderTableSection.cpp
diff --git a/Source/core/rendering/RenderTableSection.cpp b/Source/core/rendering/RenderTableSection.cpp
index 7bd443359e355938b2044e683827cb9af469f036..b0b6871ab7bb5d3cb68c3c45139bf4c3b2789ebf 100644
--- a/Source/core/rendering/RenderTableSection.cpp
+++ b/Source/core/rendering/RenderTableSection.cpp
@@ -1162,7 +1162,7 @@ void RenderTableSection::paint(PaintInfo& paintInfo, const LayoutPoint& paintOff
LayoutPoint adjustedPaintOffset = paintOffset + location();
- PaintPhase phase = paintInfo.phase;
+ PaintPhase phase = paintInfo.getPhase();
bool pushedClip = pushContentsClip(paintInfo, adjustedPaintOffset);
paintObject(paintInfo, adjustedPaintOffset);
if (pushedClip)
@@ -1190,7 +1190,7 @@ static inline bool compareCellPositionsWithOverflowingCells(RenderTableCell* ele
void RenderTableSection::paintCell(RenderTableCell* cell, PaintInfo& paintInfo, const LayoutPoint& paintOffset)
{
LayoutPoint cellPoint = flipForWritingModeForChild(cell, paintOffset);
- PaintPhase paintPhase = paintInfo.phase;
+ PaintPhase paintPhase = paintInfo.getPhase();
RenderTableRow* row = toRenderTableRow(cell->parent());
if (paintPhase == PaintPhaseBlockBackground || paintPhase == PaintPhaseChildBlockBackground) {
@@ -1326,9 +1326,9 @@ CellSpan RenderTableSection::spannedColumns(const LayoutRect& flippedRect) const
void RenderTableSection::paintObject(PaintInfo& paintInfo, const LayoutPoint& paintOffset)
{
- PaintPhase paintPhase = paintInfo.phase;
+ PaintPhase paintPhase = paintInfo.getPhase();
- LayoutRect localRepaintRect = paintInfo.rect;
+ LayoutRect localRepaintRect = paintInfo.getRect();
localRepaintRect.moveBy(-paintOffset);
localRepaintRect.inflate(maximalOutlineSize(paintPhase));
@@ -1339,7 +1339,7 @@ void RenderTableSection::paintObject(PaintInfo& paintInfo, const LayoutPoint& pa
if (dirtiedColumns.start() < dirtiedColumns.end()) {
if (!m_hasMultipleCellLevels && !m_overflowingCells.size()) {
- if (paintInfo.phase == PaintPhaseCollapsedTableBorders) {
+ if (paintInfo.getPhase() == PaintPhaseCollapsedTableBorders) {
// Collapsed borders are painted from the bottom right to the top left so that precedence
// due to cell position is respected.
for (unsigned r = dirtiedRows.end(); r > dirtiedRows.start(); r--) {
@@ -1411,7 +1411,7 @@ void RenderTableSection::paintObject(PaintInfo& paintInfo, const LayoutPoint& pa
else
std::sort(cells.begin(), cells.end(), compareCellPositionsWithOverflowingCells);
- if (paintInfo.phase == PaintPhaseCollapsedTableBorders) {
+ if (paintInfo.getPhase() == PaintPhaseCollapsedTableBorders) {
for (unsigned i = cells.size(); i > 0; --i) {
LayoutPoint cellPoint = flipForWritingModeForChild(cells[i - 1], paintOffset);
cells[i - 1]->paintCollapsedBorders(paintInfo, cellPoint);

Powered by Google App Engine
This is Rietveld 408576698