Source/core/rendering/RenderRegion.cpp - Issue 21430003: Implement interfaces in PaintInfo and make it a class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderRegion.cpp

Issue 21430003: Implement interfaces in PaintInfo and make it a class. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@getterPaintInfo01

Patch Set: Fixed Linux compilation (hopefuly Windows too), addressing some reviewer's suggestions. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/PaintInfo.h ('K') | « Source/core/rendering/RenderObject.cpp ('k') | Source/core/rendering/RenderReplaced.cpp » ('j') | Source/core/rendering/svg/SVGRenderingContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderRegion.cpp

diff --git a/Source/core/rendering/RenderRegion.cpp b/Source/core/rendering/RenderRegion.cpp

index 203d207afa8b76d2b40bd1781b838e356578728f..bffa9a0569fc73f7a9f1c0e3785b68a28fd37879 100644

--- a/Source/core/rendering/RenderRegion.cpp

+++ b/Source/core/rendering/RenderRegion.cpp

@@ -176,7 +176,7 @@ void RenderRegion::paintObject(PaintInfo& paintInfo, const LayoutPoint& paintOff

// RenderFlowThread is a self painting layer (being a positioned object) who is painting its children, the collected objects.

// Since we do not want to paint the flow thread content multiple times (for each painting phase of the region object),

// we allow the flow thread painting only for the selection and the foreground phase.

- if (!isValid() || (paintInfo.phase != PaintPhaseForeground && paintInfo.phase != PaintPhaseSelection))

+ if (!isValid() || (paintInfo.getPhase() != PaintPhaseForeground && paintInfo.getPhase() != PaintPhaseSelection))

return;

setRegionObjectsRegionStyle();