Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1477)

Unified Diff: Source/core/rendering/RenderDetailsMarker.cpp

Issue 21430003: Implement interfaces in PaintInfo and make it a class. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@getterPaintInfo01
Patch Set: Fixed Linux compilation (hopefuly Windows too), addressing some reviewer's suggestions. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderDetailsMarker.cpp
diff --git a/Source/core/rendering/RenderDetailsMarker.cpp b/Source/core/rendering/RenderDetailsMarker.cpp
index b6ab9a2ea0e2bb900965970650d5be07eb7bba10..6f162a74fba3cce0ac66c8bb4ec3067d7da88b84 100644
--- a/Source/core/rendering/RenderDetailsMarker.cpp
+++ b/Source/core/rendering/RenderDetailsMarker.cpp
@@ -113,7 +113,7 @@ Path RenderDetailsMarker::getPath(const LayoutPoint& origin) const
void RenderDetailsMarker::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset)
{
- if (paintInfo.phase != PaintPhaseForeground || style()->visibility() != VISIBLE) {
+ if (paintInfo.getPhase() != PaintPhaseForeground || style()->visibility() != VISIBLE) {
RenderBlock::paint(paintInfo, paintOffset);
return;
}
@@ -121,19 +121,19 @@ void RenderDetailsMarker::paint(PaintInfo& paintInfo, const LayoutPoint& paintOf
LayoutPoint boxOrigin(paintOffset + location());
LayoutRect overflowRect(visualOverflowRect());
overflowRect.moveBy(boxOrigin);
- overflowRect.inflate(maximalOutlineSize(paintInfo.phase));
+ overflowRect.inflate(maximalOutlineSize(paintInfo.getPhase()));
- if (!paintInfo.rect.intersects(pixelSnappedIntRect(overflowRect)))
+ if (!paintInfo.getRect().intersects(pixelSnappedIntRect(overflowRect)))
return;
const Color color(resolveColor(CSSPropertyColor));
- paintInfo.context->setStrokeColor(color);
- paintInfo.context->setStrokeStyle(SolidStroke);
- paintInfo.context->setStrokeThickness(1.0f);
- paintInfo.context->setFillColor(color);
+ paintInfo.getContext()->setStrokeColor(color);
+ paintInfo.getContext()->setStrokeStyle(SolidStroke);
+ paintInfo.getContext()->setStrokeThickness(1.0f);
+ paintInfo.getContext()->setFillColor(color);
boxOrigin.move(borderLeft() + paddingLeft(), borderTop() + paddingTop());
- paintInfo.context->fillPath(getPath(boxOrigin));
+ paintInfo.getContext()->fillPath(getPath(boxOrigin));
}
bool RenderDetailsMarker::isOpen() const

Powered by Google App Engine
This is Rietveld 408576698