Source/core/rendering/RenderBox.h - Issue 21430003: Implement interfaces in PaintInfo and make it a class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBox.h

Issue 21430003: Implement interfaces in PaintInfo and make it a class. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@getterPaintInfo01

Patch Set: Fixed Linux compilation (hopefuly Windows too), addressing some reviewer's suggestions. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/PaintInfo.h ('K') | « Source/core/rendering/RenderBlock.cpp ('k') | Source/core/rendering/RenderBox.cpp » ('j') | Source/core/rendering/svg/SVGRenderingContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBox.h

diff --git a/Source/core/rendering/RenderBox.h b/Source/core/rendering/RenderBox.h

index 24562dc32f82d82a9400e8d74a6ec4f6c3fdc9b2..d3271b3ccfd51a25dea202e213299289de90aabf 100644

--- a/Source/core/rendering/RenderBox.h

+++ b/Source/core/rendering/RenderBox.h

@@ -32,7 +32,7 @@ namespace WebCore {

class RenderBoxRegionInfo;

class RenderRegion;

-struct PaintInfo;

+class PaintInfo;

enum SizeType { MainOrPreferredSize, MinSize, MaxSize };

enum AvailableLogicalHeightType { ExcludeMarginBorderPadding, IncludeMarginBorderPadding };

@@ -593,12 +593,12 @@ protected:

virtual bool foregroundIsKnownToBeOpaqueInRect(const LayoutRect& localRect, unsigned maxDepthToTest) const;

virtual bool computeBackgroundIsKnownToBeObscured() OVERRIDE;

- void paintBackground(const PaintInfo&, const LayoutRect&, BackgroundBleedAvoidance = BackgroundBleedNone);

+ void paintBackground(PaintInfo&, const LayoutRect&, BackgroundBleedAvoidance = BackgroundBleedNone);

- void paintFillLayer(const PaintInfo&, const Color&, const FillLayer*, const LayoutRect&, BackgroundBleedAvoidance, CompositeOperator, RenderObject* backgroundObject);

- void paintFillLayers(const PaintInfo&, const Color&, const FillLayer*, const LayoutRect&, BackgroundBleedAvoidance = BackgroundBleedNone, CompositeOperator = CompositeSourceOver, RenderObject* backgroundObject = 0);

+ void paintFillLayer(PaintInfo&, const Color&, const FillLayer*, const LayoutRect&, BackgroundBleedAvoidance, CompositeOperator, RenderObject* backgroundObject);

+ void paintFillLayers(PaintInfo&, const Color&, const FillLayer*, const LayoutRect&, BackgroundBleedAvoidance = BackgroundBleedNone, CompositeOperator = CompositeSourceOver, RenderObject* backgroundObject = 0);

- void paintMaskImages(const PaintInfo&, const LayoutRect&);

+ void paintMaskImages(PaintInfo&, const LayoutRect&);

BackgroundBleedAvoidance determineBackgroundBleedAvoidance(GraphicsContext*) const;

bool backgroundHasOpaqueTopLayer() const;

@@ -613,7 +613,7 @@ protected:

virtual void mapLocalToContainer(const RenderLayerModelObject* repaintContainer, TransformState&, MapCoordinatesFlags = ApplyContainerFlip, bool* wasFixed = 0) const OVERRIDE;

virtual void mapAbsoluteToLocalPoint(MapCoordinatesFlags, TransformState&) const;

- void paintRootBoxFillLayers(const PaintInfo&);

+ void paintRootBoxFillLayers(PaintInfo&);

RenderObject* splitAnonymousBoxesAroundChild(RenderObject* beforeChild);

« Source/core/rendering/PaintInfo.h ('K') | « Source/core/rendering/RenderBlock.cpp ('k') | Source/core/rendering/RenderBox.cpp » ('j') | Source/core/rendering/svg/SVGRenderingContext.cpp » ('J')