Implement interfaces in PaintInfo and make it a class.

Source/core/rendering/PaintInfo.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  *           (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 31 matching lines @@
 class RenderLayerModelObject;
 class RenderObject;
 class RenderRegion;
 
 typedef HashMap<OverlapTestRequestClient*, IntRect> OverlapTestRequestMap;
 
 /*
  * Paint the object and its children, clipped by (x|y|w|h).
  * (tx|ty) is the calculated position of the parent
  */
-struct PaintInfo {
+class PaintInfo {
+public:
     PaintInfo(GraphicsContext* newContext, const IntRect& newRect, PaintPhase newPhase, PaintBehavior newPaintBehavior,
         RenderObject* newPaintingRoot = 0, RenderRegion* region = 0, ListHashSet<RenderInline*>* newOutlineObjects = 0,
         OverlapTestRequestMap* overlapTestRequests = 0, const RenderLayerModelObject* newPaintContainer = 0)
         : context(newContext)
         , rect(newRect)
         , phase(newPhase)
         , paintBehavior(newPaintBehavior)
         , paintingRoot(newPaintingRoot)
         , renderRegion(region)
         , outlineObjects(newOutlineObjects)
@@ skipping 32 matching lines @@
         context->concatCTM(localToAncestorTransform);
 
         if (rect == infiniteRect())
             return;
 
         rect = localToAncestorTransform.inverse().mapRect(rect);
     }
 
     static IntRect infiniteRect() { return IntRect(LayoutRect::infiniteRect()); }
 
-    // FIXME: Introduce setters/getters at some point. Requires a lot of changes throughout rendering/.
+    GraphicsContext* getContext() { return context; }

[do-not-use, 2013/08/01 18:50:14]

We usually don't use 'get' prefix for getters, so this would be called
"context()".

+    void setContext(GraphicsContext *acontext) { context = acontext; }

[do-not-use, 2013/08/01 18:50:14]

* on wrong side.

[do-not-use, 2013/08/01 18:50:14]

acontext -> context once you rename the member to m_context.

[Savago-old, 2013/08/02 14:56:56]

Ouch! You are right, I guess the check-style script forgot this one. I will fix
it.

+
+    IntRect& getRect() { return rect; }
+    void setRect(const IntRect &arect) { rect = arect; }

[do-not-use, 2013/08/01 18:50:14]

Space should be after the &, not before.

[Savago-old, 2013/08/02 14:56:56]

Same case.

+
+    const PaintPhase& getPhase() const { return phase; }
+    void setPhase(const PaintPhase& param) { phase = param; }
+
+    RenderRegion* getRenderRegion() { return renderRegion; }
+    OverlapTestRequestMap* getOverlapTestRequests() { return overlapTestRequests; }
+    void setOverlapTestRequests(OverlapTestRequestMap* map) { overlapTestRequests = map; }
+
+    ListHashSet<RenderInline*>* getOutlineObjects() { return outlineObjects; }
+    void setOutlineObjects(ListHashSet<RenderInline*>* objects) { outlineObjects = objects; }
+
+    const RenderLayerModelObject* getPaintContainer() { return paintContainer; }

[do-not-use, 2013/08/01 18:50:14]

Getter can be const since you return a const pointer.

+
+private:
     GraphicsContext* context;

[do-not-use, 2013/08/01 18:50:14]

now that those are private, we should really use m_ prefix.

[Savago-old, 2013/08/02 14:56:56]

Nice suggestion, I will update the patch.

     IntRect rect;
     PaintPhase phase;
     PaintBehavior paintBehavior;
     RenderObject* paintingRoot; // used to draw just one element and its visual kids
     RenderRegion* renderRegion;
     ListHashSet<RenderInline*>* outlineObjects; // used to list outlines that should be painted by a block with inline children
     OverlapTestRequestMap* overlapTestRequests;
     const RenderLayerModelObject* paintContainer; // the layer object that originates the current painting
 };
 
 } // namespace WebCore
 
 #endif // PaintInfo_h