Allow InstanceMirror.invoke to find private members. Resolves issue 11771.

runtime/lib/mirrors.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 #include "include/dart_debugger_api.h"
 #include "include/dart_mirrors_api.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_state.h"  // TODO(11742): Remove with CreateMirrorRef.
 #include "vm/bootstrap_natives.h"
 #include "vm/dart_entry.h"
 #include "vm/exceptions.h"
 #include "vm/message.h"
 #include "vm/object_store.h"
 #include "vm/port.h"
-#include "vm/resolver.h"
 #include "vm/symbols.h"
 #include "lib/invocation_mirror.h"
 
 namespace dart {
 
 static RawInstance* CreateMirror(const String& mirror_class_name,
                                  const Array& constructor_arguments) {
   const Library& mirrors_lib = Library::Handle(Library::MirrorsLibrary());
   const String& constructor_name = Symbols::Dot();
 
@@ skipping 699 matching lines @@
       Array::Handle(Array::New(number_of_arguments + 1));  // Plus receiver.
   Object& arg = Object::Handle();
   args.SetAt(0, reflectee);
   for (int i = 0; i < number_of_arguments; i++) {
     arg = positional_args.At(i);
     args.SetAt(i + 1, arg);  // Plus receiver.
   }
 
   ArgumentsDescriptor args_desc(
       Array::Handle(ArgumentsDescriptor::New(args.Length())));
-  // TODO(11771): This won't find private members.
-  const Function& function = Function::Handle(
-      Resolver::ResolveDynamic(reflectee,
-                               function_name,
-                               args_desc));
+
+  Class& klass = Class::Handle(reflectee.clazz());
+  Function& function = Function::Handle();
+  while (!klass.IsNull()) {
+    function = klass.LookupDynamicFunctionAllowPrivate(function_name);
+    if (!function.IsNull()) {
+      break;
+    }
+    klass = klass.SuperClass();
+  }
+
+  if (!function.IsNull() &&
+      !function.AreValidArguments(args_desc, NULL)) {
+    function = Function::null();
+  }
 
   return ReflectivelyInvokeDynamicFunction(reflectee,
                                            function,
                                            function_name,
                                            args);
 }
 
 
 DEFINE_NATIVE_ENTRY(InstanceMirror_invokeGetter, 3) {
   // Argument 0 is the mirror, which is unused by the native. It exists
@@ skipping 563 matching lines @@
 
 DEFINE_NATIVE_ENTRY(VariableMirror_type, 1) {
   GET_NON_NULL_NATIVE_ARGUMENT(MirrorReference, ref, arguments->NativeArgAt(0));
   const Field& field = Field::Handle(ref.GetFieldReferent());
 
   const AbstractType& type = AbstractType::Handle(field.type());
   return CreateTypeMirror(type);
 }
 
 }  // namespace dart