Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2142993002: Revert of Rietveld: rely on CQ to decide whether to send email. (Closed)

Created:
4 years, 5 months ago by tandrii(chromium)
Modified:
4 years, 5 months ago
Reviewers:
Sergiy Byelozyorov
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Revert of Rietveld: rely on CQ to decide whether to send email. (patchset #2 id:20001 of https://codereview.chromium.org/2137553002/ ) Reason for revert: has a bug. Original issue's description: > Rietveld: rely on CQ to decide whether to send email. > > Also cleaned up unused form entry from https://codereview.appspot.com/8693043/. > > R=sergiyb@chromium.org > BUG=626427 > > Committed: https://chromium.googlesource.com/infra/infra/+/b7213fb5c56cb0cb5db79b97259e9a5077819de8 TBR=sergiyb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=626427 Committed: https://chromium.googlesource.com/infra/infra/+/e13f93cbf0da21902685011674110a08011eb067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -44 lines) Patch
M appengine/chromium_rietveld/codereview/models.py View 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/chromium_rietveld/codereview/utils.py View 1 chunk +12 lines, -10 lines 0 comments Download
M appengine/chromium_rietveld/codereview/views.py View 4 chunks +22 lines, -27 lines 0 comments Download
M appengine/chromium_rietveld/tests/test_utils.py View 1 chunk +16 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
tandrii(chromium)
Created Revert of Rietveld: rely on CQ to decide whether to send email.
4 years, 5 months ago (2016-07-12 15:44:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142993002/1
4 years, 5 months ago (2016-07-12 15:44:09 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 15:44:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/e13f93cbf0da21902685011674110...

Powered by Google App Engine
This is Rietveld 408576698