Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3093)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 2142983002: Add desktop engagement metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_list_observer.h ('k') | chrome/browser/ui/tab_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index fe57b60959cd860ae806f44e7af9aa9b210dcb1d..69e51c3c192e9fca16e2cfa622d8de452ad735cc 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -58,7 +58,6 @@
#include "chrome/browser/ui/cocoa/fullscreen_low_power_coordinator.h"
#import "chrome/browser/ui/cocoa/fullscreen_window.h"
#import "chrome/browser/ui/cocoa/infobars/infobar_container_controller.h"
-#include "chrome/browser/ui/cocoa/last_active_browser_cocoa.h"
#import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.h"
#import "chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h"
#import "chrome/browser/ui/cocoa/profiles/avatar_base_controller.h"
@@ -598,9 +597,10 @@ bool IsTabDetachingInFullscreenEnabled() {
// Called right after our window became the main window.
- (void)windowDidBecomeMain:(NSNotification*)notification {
- if (chrome::GetLastActiveBrowser() != browser_.get()) {
- BrowserList::SetLastActive(browser_.get());
- }
+ // Set this window as active even if the previously active windows was the
+ // same one. This is needed for tracking visibility changes of a browser.
+ BrowserList::SetLastActive(browser_.get());
+
// Always saveWindowPositionIfNeeded when becoming main, not just
// when |browser_| is not the last active browser. See crbug.com/536280 .
[self saveWindowPositionIfNeeded];
@@ -624,6 +624,8 @@ bool IsTabDetachingInFullscreenEnabled() {
extensions::ExtensionCommandsGlobalRegistry::Get(browser_->profile())
->set_registry_for_active_window(nullptr);
+
+ BrowserList::NotifyBrowserNoLongerActive(browser_.get());
}
// Called when we have been minimized.
« no previous file with comments | « chrome/browser/ui/browser_list_observer.h ('k') | chrome/browser/ui/tab_helpers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698