chrome/browser/android/metrics/uma_session_stats.cc - Issue 2142983002: Add desktop engagement metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/metrics/uma_session_stats.cc

Issue 2142983002: Add desktop engagement metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/metrics/uma_session_stats.cc

diff --git a/chrome/browser/android/metrics/uma_session_stats.cc b/chrome/browser/android/metrics/uma_session_stats.cc

index ddc6ac4fa390b440e6a777600c6803ded2a6306d..352fd3aa1fcd690b2c414a22b7d6791191bb781c 100644

--- a/chrome/browser/android/metrics/uma_session_stats.cc

+++ b/chrome/browser/android/metrics/uma_session_stats.cc

@@ -61,6 +61,9 @@ void UmaSessionStats::UmaEndSession(JNIEnv* env,

if (active_session_count_ == 0) {

base::TimeDelta duration = base::TimeTicks::Now() - session_start_time_;

+ // Note: This metric is recorded separately on desktop in

+ // DesktopEngagementService::EndSession.

UMA_HISTOGRAM_LONG_TIMES("Session.TotalDuration", duration);

DCHECK(g_browser_process);