Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 2142983002: Add desktop engagement metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index a93e7fc9b0ab471f5568e8b38c206742dc1db617..5ecf4b0f5e0ee3d29655cb29ed95df7612294b54 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -267,6 +267,10 @@
#include "services/shell/runner/common/client_util.h"
#endif
+#if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX)
chrisha 2016/07/29 15:21:25 Will this also work for ChromeOS?
gayane -on leave until 09-2017 2016/07/29 19:37:38 Not sure, maybe there will be need for extra Chrom
+#include "chrome/browser/metrics/desktop_engagement/desktop_engagement_service.h"
+#endif
+
using content::BrowserThread;
namespace {
@@ -790,6 +794,10 @@ void ChromeBrowserMainParts::SetupMetricsAndFieldTrials() {
// that was already chosen.
sampling_profiler_config_.RegisterSyntheticFieldTrial();
+#if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX)
+ metrics::DesktopEngagementService::Initialize();
+#endif // defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX)
chrisha 2016/07/29 15:21:25 ubernit: I find the "#endif // blah" comments use
gayane -on leave until 09-2017 2016/07/29 19:37:38 Done.
+
#if defined(OS_WIN)
chrome_browser::SetupPreReadFieldTrial();
#endif // defined(OS_WIN)

Powered by Google App Engine
This is Rietveld 408576698