chrome/browser/ui/cocoa/browser_window_controller.mm - Issue 2142983002: Add desktop engagement metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 2142983002: Add desktop engagement metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments and fix mac bot Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_controller.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm

index 0f9b7296a03c4420f1671ce6bcc379ce44020d32..404ace1e42e309458ebec556de93c70e32de73d9 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm

@@ -624,6 +624,8 @@ bool IsTabDetachingInFullscreenEnabled() {

extensions::ExtensionCommandsGlobalRegistry::Get(browser_->profile())

->set_registry_for_active_window(nullptr);

+ BrowserList::NotifyBrowserNoLongerActive(browser_.get());

}

// Called when we have been minimized.