chrome/browser/ui/tab_helpers.cc - Issue 2142983002: Add desktop engagement metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 2142983002: Add desktop engagement metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/tab_helpers.cc

diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc

index 2981c676900ba05bc351b550f60950b1ea2eb1a6..425245ff594d61f3ad79b5f164fe326794f0510d 100644

--- a/chrome/browser/ui/tab_helpers.cc

+++ b/chrome/browser/ui/tab_helpers.cc

@@ -16,6 +16,7 @@

#include "chrome/browser/history/history_tab_helper.h"

#include "chrome/browser/history/top_sites_factory.h"

#include "chrome/browser/infobars/infobar_service.h"

+#include "chrome/browser/metrics/desktop_engagement/desktop_engagement_observer.h"

#include "chrome/browser/net/net_error_tab_helper.h"

#include "chrome/browser/net/predictor_tab_helper.h"

#include "chrome/browser/page_load_metrics/page_load_metrics_initialize.h"

@@ -194,6 +195,7 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {

VoiceSearchTabHelper::CreateForWebContents(web_contents);

#else

BookmarkTabHelper::CreateForWebContents(web_contents);

+ DesktopEngagementObserver::CreateForWebContents(web_contents);

extensions::ChromeExtensionWebContentsObserver::CreateForWebContents(

web_contents);

extensions::WebNavigationTabObserver::CreateForWebContents(web_contents);