Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: chrome/browser/metrics/desktop_engagement/audible_contents_tracker.cc

Issue 2142983002: Add desktop engagement metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/metrics/desktop_engagement/audible_contents_tracker.h"
6
7 #include "chrome/browser/ui/browser.h"
8 #include "chrome/browser/ui/browser_list.h"
9 #include "chrome/browser/ui/tabs/tab_strip_model.h"
10
11 namespace metrics {
12
13 AudibleContentsTracker::AudibleContentsTracker(Observer* observer)
14 : observer_(observer) {
15 auto browser_list = BrowserList::GetInstance();
16 for (const auto browser : *browser_list)
Alexei Svitkine (slow) 2016/07/26 19:20:36 Nit: See recent chromium-dev discussion, basically
gayane -on leave until 09-2017 2016/07/26 21:41:18 Done.
17 browser->tab_strip_model()->AddObserver(this);
18 browser_list->AddObserver(this);
19 }
20
21 AudibleContentsTracker::~AudibleContentsTracker() {}
22
23 void AudibleContentsTracker::OnBrowserAdded(Browser* browser) {
24 browser->tab_strip_model()->AddObserver(this);
25 }
26
27 void AudibleContentsTracker::OnBrowserRemoved(Browser* browser) {
28 browser->tab_strip_model()->RemoveObserver(this);
29 }
30
31 void AudibleContentsTracker::TabClosingAt(TabStripModel* model,
32 content::WebContents* web_contents,
33 int index) {
34 RemoveAudibleWebContents(web_contents);
35 }
36
37 void AudibleContentsTracker::TabChangedAt(content::WebContents* web_contents,
38 int index,
39 TabChangeType change_type) {
40 // Ignore 'loading' and 'title' changes.
41 if (change_type != TabStripModelObserver::ALL)
42 return;
43
44 if (web_contents->WasRecentlyAudible()) {
Alexei Svitkine (slow) 2016/07/26 19:20:36 Nit: No {}'s
gayane -on leave until 09-2017 2016/07/26 21:41:18 Done.
45 AddAudibleWebContents(web_contents);
46 } else {
47 RemoveAudibleWebContents(web_contents);
48 }
49 }
50
51 void AudibleContentsTracker::TabReplacedAt(
52 TabStripModel* model,
53 content::WebContents* old_web_contents,
54 content::WebContents* new_web_contents,
55 int index) {
56 RemoveAudibleWebContents(old_web_contents);
57 if (new_web_contents->WasRecentlyAudible())
58 AddAudibleWebContents(new_web_contents);
59 }
60
61 void AudibleContentsTracker::AddAudibleWebContents(
62 content::WebContents* web_contents) {
63 // The first web contents to become audible indicates that audio has started.
64 bool added = audible_contents_.insert(web_contents).second;
65 if (added && audible_contents_.size() == 1)
66 observer_->OnAudioStart();
67 }
68
69 void AudibleContentsTracker::RemoveAudibleWebContents(
70 content::WebContents* web_contents) {
71 bool removed = (audible_contents_.erase(web_contents) == 1);
Alexei Svitkine (slow) 2016/07/26 19:20:36 Add a comment about this logic please.
gayane -on leave until 09-2017 2016/07/26 21:41:18 Done.
72 if (removed && audible_contents_.empty())
73 observer_->OnAudioEnd();
74 }
75
76 } // namespace metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698