Add desktop engagement metrics.

chrome/browser/metrics/desktop_engagement/audible_contents_tracker_browsertest.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+#include "chrome/browser/metrics/desktop_engagement/audible_contents_tracker.h"
+
+#include "base/path_service.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "chrome/test/base/ui_test_utils.h"
+#include "content/public/test/browser_test_base.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+// Observer for testing AudibleContentsTracker.
+class MockAudibleContentsObserver
+    : public metrics::AudibleContentsTracker::Observer {
+ public:
+  MockAudibleContentsObserver() { new metrics::AudibleContentsTracker(this); }

[chrisha, 2016/07/22 19:54:56]

The AudibleContentsTracker isn't owned by anyone and gets leaked?

[gayane -on leave until 09-2017, 2016/07/22 21:11:49]

Moved to AudibleContentsTrackerTest

+
+  // AudibleContentsTracker::Observer:
+  void OnAudioStart() override { is_audio_playing_ = true; }
+  void OnAudioEnd() override { is_audio_playing_ = false; }
+
+  bool IsAudioPlaying() { return is_audio_playing_; }
+
+ private:
+  bool is_audio_playing_ = false;
+
+  DISALLOW_COPY_AND_ASSIGN(MockAudibleContentsObserver);
+};
+
+}  // namespace
+
+class AudibleContentsTrackerTest : public InProcessBrowserTest {
+ public:
+  AudibleContentsTrackerTest() {
+    observer_.reset(new MockAudibleContentsObserver());
+  }
+  MockAudibleContentsObserver* GetObserver() { return observer_.get(); }

[chrisha, 2016/07/22 19:54:56]

Just make this an accessor?

Mock.... observer() const { return observer_.get(); }

[gayane -on leave until 09-2017, 2016/07/22 21:11:49]

Done.

+

[chrisha, 2016/07/22 19:54:56]

I would do something like:

std::unique_ptr<MockAudibleContentsObserver> observer_;
std::unique_ptr<metrics::AudibleContentsTracker> tracker_;

void SetUp() override {
  observer_ = new ...;
  tracker_ = new ...(observer_);
}

void TearDown() override {
  tracker_.reset();
  observer_.reset();
}

[gayane -on leave until 09-2017, 2016/07/22 21:11:49]

Done.

+ private:
+  std::unique_ptr<MockAudibleContentsObserver> observer_ = nullptr;

[chrisha, 2016/07/22 19:54:56]

No std::unique_ptr<metrics::AudibleContentsTracker> ?

[gayane -on leave until 09-2017, 2016/07/22 21:11:49]

Done.

+};
+
+IN_PROC_BROWSER_TEST_F(AudibleContentsTrackerTest, test) {
+  MockAudibleContentsObserver* observer = GetObserver();
+  EXPECT_FALSE(observer->IsAudioPlaying());
+
+  // For serving audio.
+  ASSERT_TRUE(embedded_test_server()->Start());
+  base::FilePath test_data_dir;
+  ASSERT_TRUE(PathService::Get(base::DIR_SOURCE_ROOT, &test_data_dir));
+  embedded_test_server()->ServeFilesFromDirectory(
+      test_data_dir.AppendASCII("chrome/test/data/"));
+  ui_test_utils::NavigateToURL(
+      browser(), embedded_test_server()->GetURL("/autoplay_audio.html"));
+
+  // Wait until the audio starts.
+  while (!observer->IsAudioPlaying()) {
+    base::RunLoop().RunUntilIdle();
+  }
+
+  // Wait until the audio stops.
+  while (observer->IsAudioPlaying()) {
+    base::RunLoop().RunUntilIdle();
+  }
+}