Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2142963002: Add passive: false to touch_scheduling_cases to avoid interventions. (Closed)

Created:
4 years, 5 months ago by dtapuska
Modified:
4 years, 5 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org, tdresser
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add passive: false to touch_scheduling_cases to avoid interventions. The page sets are specifically tracking prevent defaulting events and causing scrolling on the main thread. We should set them as passive: false to avoid the root scroller intervention. BUG=627083 Committed: https://crrev.com/799f1ac42b56c604bf24c6e603bccebae3026d61 Cr-Commit-Position: refs/heads/master@{#404880}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M tools/perf/page_sets/tough_scheduling_cases/raf_touch_animation.html View 1 chunk +4 lines, -3 lines 0 comments Download
M tools/perf/page_sets/tough_scheduling_cases/touch_handler_scrolling.html View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
dtapuska
4 years, 5 months ago (2016-07-12 14:59:19 UTC) #2
dtapuska
On 2016/07/12 14:59:19, dtapuska wrote: +sullivan; seems Sami is OOO
4 years, 5 months ago (2016-07-12 15:03:51 UTC) #5
sullivan
lgtm
4 years, 5 months ago (2016-07-12 15:05:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142963002/1
4 years, 5 months ago (2016-07-12 19:16:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 01:38:57 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 01:39:48 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 01:41:34 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/799f1ac42b56c604bf24c6e603bccebae3026d61
Cr-Commit-Position: refs/heads/master@{#404880}

Powered by Google App Engine
This is Rietveld 408576698