test/cctest/test-thread-termination.cc - Issue 2142933003: Move Error methods to C++

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-thread-termination.cc

Issue 2142933003: Move Error methods to C++ (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-thread-termination.cc

diff --git a/test/cctest/test-thread-termination.cc b/test/cctest/test-thread-termination.cc

index 9d3cbf61960a2a0db75d4b1fb1dac3b1fcedd3f2..06e6fb00cdf34940e8d659bc87cdd3be604eb65f 100644

--- a/test/cctest/test-thread-termination.cc

+++ b/test/cctest/test-thread-termination.cc

@@ -517,8 +517,7 @@ TEST(ErrorObjectAfterTermination) {

v8::Context::Scope context_scope(context);

isolate->TerminateExecution();

v8::Local<v8::Value> error = v8::Exception::Error(v8_str("error"));

- // TODO(yangguo): crbug/403509. Check for empty handle instead.

- CHECK(error->IsUndefined());

+ CHECK(error->IsNativeError());

}