Use a single GC instead of multiple GCs on fast/forms/select-set-length-with-mutation-remove.html

Use a single GC instead of multiple GCs on fast/forms/select-set-length-with-mutation-remove.html

r170014 changed multiple GCs to be default, but this test seems to issue GC too much.
This CL modifies the test to call a single GC instead of multiple GCs to avoid taking too much time on the test.
This matches the previous behavior before r170014

BUG=357001
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170145

[haraken, 2014-03-27 05:42:32]

I don't see a reason why this test issues so many GCs. onRemove() will be called
just several times, won't it?

[tkent, 2014-03-27 05:43:46]

lgtm.  Please update TestExpectations too.

This is ok, but we should understand what's wrong with collectAll().  Is
collectAll() extremely slow?

[haraken, 2014-03-27 05:45:00]

On 2014/03/27 05:43:46, tkent wrote:
> lgtm.  Please update TestExpectations too.
> 
> This is ok, but we should understand what's wrong with collectAll().  Is
> collectAll() extremely slow?

collectAll() calls 7 V8 GCs to make sure that all wrapper chains are broken. So,
very roughly speaking, it should be at most 7 times slower than collect().

[kouhei (in TOK), 2014-03-27 05:49:55]

On 2014/03/27 05:43:46, tkent wrote:
> lgtm.  Please update TestExpectations too.
> 
> This is ok, but we should understand what's wrong with collectAll().  Is
> collectAll() extremely slow?

Done.

[kouhei (in TOK), 2014-03-27 05:49:58]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-03-27 05:50:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kouhei@chromium.org/214293002/20001

[haraken, 2014-03-27 05:52:38]

How many times is onRemove() called in this test? (i.e., how many times is
collectAll() called in this test?)

[kouhei (in TOK), 2014-03-27 06:01:44]

On 2014/03/27 05:52:38, haraken wrote:
> How many times is onRemove() called in this test? (i.e., how many times is
> collectAll() called in this test?)

51 times

[haraken, 2014-03-27 06:11:14]

On 2014/03/27 06:01:44, kouhei wrote:
> On 2014/03/27 05:52:38, haraken wrote:
> > How many times is onRemove() called in this test? (i.e., how many times is
> > collectAll() called in this test?)
> 
> 51 times

Actually I'm not convinced that it's the cause of the timeout. There are few
objects involved in this test, so collectAll() shouldn't take so much time. Did
you confirm locally that this CL fixes the timeout?

In general, it's not a good thing to replace collectAll() with collect(). The
result of collect() can be non-deterministic.

[commit-bot: I haz the power, 2014-03-27 06:53:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 06:53:54]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[kouhei (in TOK), 2014-03-27 07:25:12]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-03-27 07:25:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kouhei@chromium.org/214293002/20001

[commit-bot: I haz the power, 2014-03-27 08:23:25]

Change committed as 170145