Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2142923002: Remove amp recipe module and related code (unused) (Closed)

Created:
4 years, 5 months ago by Paweł Hajdan Jr.
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -17458 lines) Patch
D scripts/slave/recipe_modules/amp/__init__.py View 1 chunk +0 lines, -16 lines 0 comments Download
D scripts/slave/recipe_modules/amp/api.py View 1 chunk +0 lines, -337 lines 0 comments Download
D scripts/slave/recipe_modules/amp/config.py View 1 chunk +0 lines, -38 lines 0 comments Download
D scripts/slave/recipe_modules/amp/example.py View 1 chunk +0 lines, -216 lines 0 comments Download
D scripts/slave/recipe_modules/amp/example.expected/bad_device_data_for_collect.json View 1 chunk +0 lines, -549 lines 0 comments Download
D scripts/slave/recipe_modules/amp/example.expected/bad_device_data_from_trigger.json View 1 chunk +0 lines, -82 lines 0 comments Download
D scripts/slave/recipe_modules/amp/example.expected/bad_test_id_data_for_upload.json View 1 chunk +0 lines, -552 lines 0 comments Download
D scripts/slave/recipe_modules/amp/example.expected/device_oem_basic.json View 1 chunk +0 lines, -562 lines 0 comments Download
D scripts/slave/recipe_modules/amp/example.expected/minimum_device_os_basic.json View 1 chunk +0 lines, -556 lines 0 comments Download
D scripts/slave/recipe_modules/amp/example.expected/multiple_device_oses_basic.json View 1 chunk +0 lines, -562 lines 0 comments Download
D scripts/slave/recipe_modules/amp/example.expected/multiple_devices_basic.json View 1 chunk +0 lines, -562 lines 0 comments Download
D scripts/slave/recipe_modules/amp/example.expected/network_config_set_basic.json View 1 chunk +0 lines, -562 lines 0 comments Download
D scripts/slave/recipe_modules/amp/example.expected/no_device_name_basic.json View 1 chunk +0 lines, -550 lines 0 comments Download
D scripts/slave/recipe_modules/amp/example.expected/no_device_os_basic.json View 1 chunk +0 lines, -550 lines 0 comments Download
D scripts/slave/recipe_modules/amp/example.expected/normal_example_basic.json View 1 chunk +0 lines, -556 lines 0 comments Download
D scripts/slave/recipe_modules/amp/example.expected/slow_tests_basic.json View 1 chunk +0 lines, -560 lines 0 comments Download
D scripts/slave/recipe_modules/amp/example.expected/split_example_basic.json View 1 chunk +0 lines, -556 lines 0 comments Download
D scripts/slave/recipe_modules/amp/example.expected/underspecified_with_timeout_basic.json View 1 chunk +0 lines, -568 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/api.py View 1 chunk +0 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 1 chunk +0 lines, -108 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/steps.py View 2 chunks +2 lines, -165 lines 0 comments Download
M scripts/slave/recipes/chromium.py View 3 chunks +1 line, -40 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/amp_split_recipe_collect_failure.json View 1 chunk +0 lines, -2740 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/amp_split_recipe_instrumentation_trigger_failure.json View 1 chunk +0 lines, -463 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/amp_split_recipe_trigger_failure.json View 1 chunk +0 lines, -2638 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Builder__dbg_.json View 3 chunks +2 lines, -63 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Tests__amp_instrumentation_test_split_.json View 1 chunk +0 lines, -565 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Tests__amp_split_.json View 1 chunk +0 lines, -2738 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Paweł Hajdan Jr.
4 years, 5 months ago (2016-07-12 13:51:02 UTC) #2
tandrii(chromium)
lgtm
4 years, 5 months ago (2016-07-12 13:52:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142923002/1
4 years, 5 months ago (2016-07-12 13:53:42 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 13:58:33 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/cd2a044ea7051c5e26c5...

Powered by Google App Engine
This is Rietveld 408576698