Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2142913002: Fix uncommon GC related reload crash (Closed)

Created:
4 years, 5 months ago by Cutch
Modified:
4 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix uncommon GC related reload crash Fixes the crashes that looked like: runtime/vm/object.h: 6185: error: expected: (value & kSmiTagMask) == kSmiTag R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/262dfebe67d2a04130769e73887503fe5de40b59

Patch Set 1 #

Total comments: 3

Patch Set 2 : asiva review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M runtime/vm/isolate_reload.cc View 1 2 chunks +16 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Cutch
4 years, 5 months ago (2016-07-12 13:50:54 UTC) #4
siva
lgtm https://codereview.chromium.org/2142913002/diff/1/runtime/vm/isolate_reload.cc File runtime/vm/isolate_reload.cc (right): https://codereview.chromium.org/2142913002/diff/1/runtime/vm/isolate_reload.cc#newcode234 runtime/vm/isolate_reload.cc:234: Maybe add ASSERT(isolate() == thread->isolate()); https://codereview.chromium.org/2142913002/diff/1/runtime/vm/isolate_reload.cc#newcode234 runtime/vm/isolate_reload.cc:234: Maybe ...
4 years, 5 months ago (2016-07-12 16:23:15 UTC) #5
Cutch
https://codereview.chromium.org/2142913002/diff/1/runtime/vm/isolate_reload.cc File runtime/vm/isolate_reload.cc (right): https://codereview.chromium.org/2142913002/diff/1/runtime/vm/isolate_reload.cc#newcode234 runtime/vm/isolate_reload.cc:234: On 2016/07/12 16:23:15, siva wrote: > Maybe add > ...
4 years, 5 months ago (2016-07-12 17:45:30 UTC) #6
Cutch
4 years, 5 months ago (2016-07-12 17:46:16 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
262dfebe67d2a04130769e73887503fe5de40b59 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698