Fix build/config/mac/gen_plist.py.

Fix build/config/mac/gen_plist.py.

When a modifier was used for a substitution, the modifier variable
value starts with a semi-colon but since the code was testing with
string without the semi-colon no substitution was performed.

The substitution rules for :identifier and :rfc1034identifier were
swapped (:rfc1034identifier is the one using '-').

If the value contained '_' the :rfc1034idenfifier modifier should
have substitued a '-' but didn't (gyp had the same issue, fixed by
https://codereview.chromium.org/2141973002/).

BUG=625875
Committed: https://crrev.com/b17a345954748b984d68e06080ad9733339f4dd2
Cr-Commit-Position: refs/heads/master@{#404814}

[sdefresne, 2016-07-12 13:25:19]

Patchset #1 (id:1) has been deleted

[sdefresne, 2016-07-12 13:28:17]

sdefresne@chromium.org changed reviewers:
+ justincohen@chromium.org

[sdefresne, 2016-07-12 13:28:17]

Please take a look and send to CQ if LGTY.

[justincohen, 2016-07-12 14:58:19]

The CQ bit was checked by justincohen@chromium.org

[justincohen, 2016-07-12 14:58:19]

lgtm

[commit-bot: I haz the power, 2016-07-12 14:59:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 18:14:40]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-07-12 18:16:37]

Description was changed from

==========
Fix build/config/mac/gen_plist.py.

When a modifier was used for a substitution, the modifier variable
value starts with a semi-colon but since the code was testing with
string without the semi-colon no substitution was performed.

The substitution rules for :identifier and :rfc1034identifier were
swapped (:rfc1034identifier is the one using '-').

If the value contained '_' the :rfc1034idenfifier modifier should
have substitued a '-' but didn't (gyp had the same issue, fixed by
https://codereview.chromium.org/2141973002/).

BUG=625875
==========

to

==========
Fix build/config/mac/gen_plist.py.

When a modifier was used for a substitution, the modifier variable
value starts with a semi-colon but since the code was testing with
string without the semi-colon no substitution was performed.

The substitution rules for :identifier and :rfc1034identifier were
swapped (:rfc1034identifier is the one using '-').

If the value contained '_' the :rfc1034idenfifier modifier should
have substitued a '-' but didn't (gyp had the same issue, fixed by
https://codereview.chromium.org/2141973002/).

BUG=625875

Committed: https://crrev.com/b17a345954748b984d68e06080ad9733339f4dd2
Cr-Commit-Position: refs/heads/master@{#404814}
==========

[commit-bot: I haz the power, 2016-07-12 18:16:38]

Patchset 1 (id:??) landed as
https://crrev.com/b17a345954748b984d68e06080ad9733339f4dd2
Cr-Commit-Position: refs/heads/master@{#404814}