Dust-off SkXMLParser

Dust-off SkXMLParser

Hook up SkXMLParser to Expat, such that it can actually parse, err,
XML.

Add a trivial unit test.

R=robertphillips@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2142893006

Committed: https://skia.googlesource.com/skia/+/7445e86bac478dea91da32473e5a01baff637c23

[f(malita), 2016-07-14 15:16:34]

Description was changed from

==========
Dust-off SkXMLParser

Hooks SkXMLParser up with Expat, such that it can actually parse, err,
XML.

Add a trivial unit test.

R=robertphillips@google.com,reed@google.com
==========

to

==========
Dust-off SkXMLParser

Hooks SkXMLParser up with Expat, such that it can actually parse, err,
XML.

Add a trivial unit test.

R=robertphillips@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2142893006
==========

[f(malita), 2016-07-14 15:16:47]

Description was changed from

==========
Dust-off SkXMLParser

Hooks SkXMLParser up with Expat, such that it can actually parse, err,
XML.

Add a trivial unit test.

R=robertphillips@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2142893006
==========

to

==========
Dust-off SkXMLParser

Hook SkXMLParser up with Expat, such that it can actually parse, err,
XML.

Add a trivial unit test.

R=robertphillips@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2142893006
==========

[f(malita), 2016-07-14 15:17:01]

Description was changed from

==========
Dust-off SkXMLParser

Hook SkXMLParser up with Expat, such that it can actually parse, err,
XML.

Add a trivial unit test.

R=robertphillips@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2142893006
==========

to

==========
Dust-off SkXMLParser

Hook up SkXMLParser to Expat, such that it can actually parse, err,
XML.

Add a trivial unit test.

R=robertphillips@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2142893006
==========

[f(malita), 2016-07-14 16:10:39]

Probably one of many cleanup CLs.

[f(malita), 2016-07-14 16:10:44]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 16:10:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 16:24:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 16:24:25]

Dry run: Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[f(malita), 2016-07-14 16:26:38]

fmalita@chromium.org changed reviewers:
+ stephana@google.com

[f(malita), 2016-07-14 16:27:33]

Trying to figure what's up with the Mac expat build failure.

[reed1, 2016-07-14 16:32:55]

lgtm

[robertphillips, 2016-07-14 16:51:40]

lgtm

https://codereview.chromium.org/2142893006/diff/40001/src/xml/SkXMLParser.cpp
File src/xml/SkXMLParser.cpp (right):

https://codereview.chromium.org/2142893006/diff/40001/src/xml/SkXMLParser.cpp...
src/xml/SkXMLParser.cpp:97: 
kBufferSize ?

[f(malita), 2016-07-14 18:20:11]

Attempting to fix the Expat build on Win/Mac here:
https://codereview.chromium.org/2150603004/

I'm kinda stuck because Mac builds seem to ignore the gyp flags I've added.  If
anyone knows what's going on... halp!

https://codereview.chromium.org/2142893006/diff/40001/src/xml/SkXMLParser.cpp
File src/xml/SkXMLParser.cpp (right):

https://codereview.chromium.org/2142893006/diff/40001/src/xml/SkXMLParser.cpp...
src/xml/SkXMLParser.cpp:97: 
On 2016/07/14 16:51:39, robertphillips wrote:
> kBufferSize ?

Done.

[stephana, 2016-07-14 18:53:22]

https://codereview.chromium.org/2142893006/diff/60001/tests/SkDOMTest.cpp
File tests/SkDOMTest.cpp (right):

https://codereview.chromium.org/2142893006/diff/60001/tests/SkDOMTest.cpp#new...
tests/SkDOMTest.cpp:30: const SkDOM::Node* root = dom.build(docStream);
Nit: 
If you called 

  ... dom.build(gDoc, sizeof(gDoc)-1); 

you would test both build functions. 
Unless I am missing something.

[f(malita), 2016-07-14 23:22:11]

https://codereview.chromium.org/2142893006/diff/60001/tests/SkDOMTest.cpp
File tests/SkDOMTest.cpp (right):

https://codereview.chromium.org/2142893006/diff/60001/tests/SkDOMTest.cpp#new...
tests/SkDOMTest.cpp:30: const SkDOM::Node* root = dom.build(docStream);
On 2016/07/14 18:53:22, stephana wrote:
> Nit: 
> If you called 
> 
>   ... dom.build(gDoc, sizeof(gDoc)-1); 
> 
> you would test both build functions. 
> Unless I am missing something. 

Done.

I was thinking we should kill that build variant since SkStream is a
generalization, but sure, let's cover it in the meantime.

[f(malita), 2016-07-14 23:22:18]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 23:22:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 23:28:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 23:28:20]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[f(malita), 2016-07-14 23:34:34]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 23:34:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 23:41:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 23:41:34]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[f(malita), 2016-07-15 01:40:31]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 01:40:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 01:55:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 01:55:07]

Dry run: This issue passed the CQ dry run.

[f(malita), 2016-07-15 02:13:09]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-07-15 02:13:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com, reed@google.com
Link to the patchset: https://codereview.chromium.org/2142893006/#ps120001
(title: "XML_STATIC for MSVC voodoo")

[commit-bot: I haz the power, 2016-07-15 02:13:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 02:14:09]

Description was changed from

==========
Dust-off SkXMLParser

Hook up SkXMLParser to Expat, such that it can actually parse, err,
XML.

Add a trivial unit test.

R=robertphillips@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2142893006
==========

to

==========
Dust-off SkXMLParser

Hook up SkXMLParser to Expat, such that it can actually parse, err,
XML.

Add a trivial unit test.

R=robertphillips@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2142893006

Committed:
https://skia.googlesource.com/skia/+/7445e86bac478dea91da32473e5a01baff637c23
==========

[commit-bot: I haz the power, 2016-07-15 02:14:10]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/7445e86bac478dea91da32473e5a01baff637c23