Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2142833002: Set proper result (purple/red) for "Uncaught Exception" and "Failure reason" steps (Closed)

Created:
4 years, 5 months ago by Paweł Hajdan Jr.
Modified:
4 years, 5 months ago
Reviewers:
estaab, iannucci, martiniss
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
https://github.com/luci/recipes-py.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Set proper result (purple/red) for "Uncaught Exception" and "Failure reason" steps BUG=none Committed: https://github.com/luci/recipes-py/commit/6bf9ca763de94c641328900358642ec44cf3932e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M recipes.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Paweł Hajdan Jr.
See e.g. https://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/88234 I think if "Uncaught Exception" is not purple it's quite confusing.
4 years, 5 months ago (2016-07-12 09:59:24 UTC) #2
martiniss
lgtm
4 years, 5 months ago (2016-07-12 19:23:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142833002/1
4 years, 5 months ago (2016-07-13 09:01:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/luci/recipes-py/commit/6bf9ca763de94c641328900358642ec44cf3932e
4 years, 5 months ago (2016-07-13 09:03:51 UTC) #11
martiniss
4 years, 5 months ago (2016-07-20 22:46:32 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2168653005/ by martiniss@chromium.org.

The reason for reverting is: Broke sheriff-o-matic
(https://screenshot.googleplex.com/td2M1aXN8S4); it caused a bunch of duplicate
alerts to show up.

I believe we can cause the step to turn purple without having it show up as a
failing step, which incorrectly triggers a lot of our sheriffing tools..

Powered by Google App Engine
This is Rietveld 408576698