Bindings: rename |jsValue| => |v8Value|

Bindings: rename |jsValue| => |v8Value|

Per request of haraken:
https://codereview.chromium.org/212593008/#msg4

TBR=haraken

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170235

[Nils Barth (inactive), 2014-03-27 05:28:32]

Ta-da!

[Nils Barth (inactive), 2014-03-27 05:28:36]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-03-27 05:28:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/214283002/1

[Nils Barth (inactive), 2014-03-27 05:29:28]

The CQ bit was unchecked by nbarth@chromium.org

[Nils Barth (inactive), 2014-03-27 05:29:51]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-03-27 05:29:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/214283002/1

[haraken, 2014-03-27 05:38:35]

LGTM

[commit-bot: I haz the power, 2014-03-27 07:12:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 07:12:12]

Failed to apply patch for Source/bindings/templates/attributes.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/templates/attributes.cpp
  Hunk #1 FAILED at 29.
  Hunk #2 succeeded at 116 (offset -2 lines).
  Hunk #3 succeeded at 200 (offset -2 lines).
  Hunk #4 succeeded at 220 (offset 3 lines).
  Hunk #5 FAILED at 243.
  Hunk #6 succeeded at 286 (offset 3 lines).
  Hunk #7 succeeded at 302 (offset 3 lines).
  Hunk #8 succeeded at 310 (offset 3 lines).
  2 out of 8 hunks FAILED -- saving rejects to file
Source/bindings/templates/attributes.cpp.rej

Patch:       Source/bindings/templates/attributes.cpp
Index: Source/bindings/templates/attributes.cpp
diff --git a/Source/bindings/templates/attributes.cpp
b/Source/bindings/templates/attributes.cpp
index
c873f3731cefbec93507d21da8e3a2cfe8bbc56f..6ec7f80c57d1506ecf2c78cfc8839144978bf332
100644
--- a/Source/bindings/templates/attributes.cpp
+++ b/Source/bindings/templates/attributes.cpp
@@ -29,9 +29,9 @@ const v8::PropertyCallbackInfo<v8::Value>& info
     v8::Handle<v8::String> propertyName = v8AtomicString(info.GetIsolate(),
"{{attribute.name}}");
     {{cpp_class}}* impl = {{v8_class}}::toNative(info.Holder());
     if (!impl->{{attribute.cached_attribute_validation_method}}()) {
-        v8::Handle<v8::Value> jsValue =
V8HiddenValue::getHiddenValue(info.GetIsolate(), info.Holder(), propertyName);
-        if (!jsValue.IsEmpty()) {
-            v8SetReturnValue(info, jsValue);
+        v8::Handle<v8::Value> v8Value =
V8HiddenValue::getHiddenValue(info.GetIsolate(), info.Holder(), propertyName);
+        if (!v8Value.IsEmpty()) {
+            v8SetReturnValue(info, v8Value);
             return;
         }
     }
@@ -118,29 +118,29 @@ const v8::PropertyCallbackInfo<v8::Value>& info
    one of those. If not, set it to the empty string.
   
http://www.whatwg.org/specs/web-apps/current-work/#limited-to-only-known-values
#}
 {% if reflect_empty %}
-if (jsValue.isNull()) {
+if (v8Value.isNull()) {
 {% if reflect_missing %}
-    jsValue = "{{reflect_missing}}";
+    v8Value = "{{reflect_missing}}";
 {% else %}
     ;
 {% endif %}
-} else if (jsValue.isEmpty()) {
-    jsValue = "{{reflect_empty}}";
+} else if (v8Value.isEmpty()) {
+    v8Value = "{{reflect_empty}}";
 {% else %}
-if (jsValue.isEmpty()) {
+if (v8Value.isEmpty()) {
 {# FIXME: should use [ReflectEmpty] instead; need to change IDL files #}
 {% if reflect_missing %}
-    jsValue = "{{reflect_missing}}";
+    v8Value = "{{reflect_missing}}";
 {% else %}
     ;
 {% endif %}
 {% endif %}
 {% for value in reflect_only_values %}
-} else if (equalIgnoringCase(jsValue, "{{value}}")) {
-    jsValue = "{{value}}";
+} else if (equalIgnoringCase(v8Value, "{{value}}")) {
+    v8Value = "{{value}}";
 {% endfor %}
 } else {
-    jsValue = "{{reflect_invalid}}";
+    v8Value = "{{reflect_invalid}}";
 }
 {% endmacro %}
 
@@ -202,9 +202,9 @@ static void
{{attribute.name}}ConstructorGetterCallback{{world_suffix}}(v8::Loca
 {% filter conditional(attribute.conditional_string) %}
 static void {{attribute.name}}AttributeSetter{{world_suffix}}(
 {%- if attribute.is_expose_js_accessors %}
-v8::Local<v8::Value> jsValue, const v8::FunctionCallbackInfo<v8::Value>& info
+v8::Local<v8::Value> v8Value, const v8::FunctionCallbackInfo<v8::Value>& info
 {%- else %}
-v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info
+v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info
 {%- endif %})
 {
     {% if attribute.is_reflect and attribute.idl_type == 'DOMString' and
@@ -217,7 +217,7 @@ v8::Local<v8::Value> jsValue, const
v8::PropertyCallbackInfo<void>& info
     {% if attribute.has_strict_type_checking %}
     {# Type checking for interface types (if interface not implemented, throw
        TypeError), per http://www.w3.org/TR/WebIDL/#es-interface #}
-    if (!isUndefinedOrNull(jsValue) &&
!V8{{attribute.idl_type}}::hasInstance(jsValue, info.GetIsolate())) {
+    if (!isUndefinedOrNull(v8Value) &&
!V8{{attribute.idl_type}}::hasInstance(v8Value, info.GetIsolate())) {
         exceptionState.throwTypeError("The provided value is not of type
'{{attribute.idl_type}}'.");
         exceptionState.throwIfNeeded();
         return;
@@ -243,7 +243,7 @@ v8::Local<v8::Value> jsValue, const
v8::PropertyCallbackInfo<void>& info
     {% if attribute.idl_type != 'EventHandler' %}
     {{attribute.v8_value_to_local_cpp_value}};
     {% elif not is_node %}{# EventHandler hack #}
-    moveEventListenerToNewWrapper(info.Holder(),
{{attribute.event_handler_getter_expression}}, jsValue,
{{v8_class}}::eventListenerCacheIndex, info.GetIsolate());
+    moveEventListenerToNewWrapper(info.Holder(),
{{attribute.event_handler_getter_expression}}, v8Value,
{{v8_class}}::eventListenerCacheIndex, info.GetIsolate());
     {% endif %}
     {% if attribute.enum_validation_expression %}
     {# Setter ignores invalid enum values:
http://www.w3.org/TR/WebIDL/#idl-enums #}
@@ -283,11 +283,11 @@ static void
{{attribute.name}}AttributeSetterCallback{{world_suffix}}(
 {%- if attribute.is_expose_js_accessors %}
 const v8::FunctionCallbackInfo<v8::Value>& info
 {%- else %}
-v8::Local<v8::String>, v8::Local<v8::Value> jsValue, const
v8::PropertyCallbackInfo<void>& info
+v8::Local<v8::String>, v8::Local<v8::Value> v8Value, const
v8::PropertyCallbackInfo<void>& info
 {%- endif %})
 {
     {% if attribute.is_expose_js_accessors %}
-    v8::Local<v8::Value> jsValue = info[0];
+    v8::Local<v8::Value> v8Value = info[0];
     {% endif %}
     TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMSetter");
     {% if attribute.deprecate_as %}
@@ -299,7 +299,7 @@ v8::Local<v8::String>, v8::Local<v8::Value> jsValue, const
v8::PropertyCallbackI
     {% if world_suffix in attribute.activity_logging_world_list_for_setter %}
     V8PerContextData* contextData =
V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
     if (contextData && contextData->activityLogger()) {
-        v8::Handle<v8::Value> loggerArg[] = { jsValue };
+        v8::Handle<v8::Value> loggerArg[] = { v8Value };
        
contextData->activityLogger()->log("{{interface_name}}.{{attribute.name}}", 1,
&loggerArg[0], "Setter");
     }
     {% endif %}
@@ -307,9 +307,9 @@ v8::Local<v8::String>, v8::Local<v8::Value> jsValue, const
v8::PropertyCallbackI
     CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
     {% endif %}
     {% if attribute.has_custom_setter %}
-    {{v8_class}}::{{attribute.name}}AttributeSetterCustom(jsValue, info);
+    {{v8_class}}::{{attribute.name}}AttributeSetterCustom(v8Value, info);
     {% else %}
-   
{{cpp_class}}V8Internal::{{attribute.name}}AttributeSetter{{world_suffix}}(jsValue,
info);
+   
{{cpp_class}}V8Internal::{{attribute.name}}AttributeSetter{{world_suffix}}(v8Value,
info);
     {% endif %}
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
 }

[Nils Barth (inactive), 2014-03-27 07:18:31]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-03-27 07:18:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/214283002/30001

[commit-bot: I haz the power, 2014-03-27 07:21:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 07:21:51]

Try jobs failed on following builders:
  tryserver.blink on blink_presubmit

[Nils Barth (inactive), 2014-03-28 00:37:30]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-03-28 00:37:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/214283002/30001

[commit-bot: I haz the power, 2014-03-28 01:08:10]

Change committed as 170235