content/renderer/bluetooth/web_bluetooth_impl.h - Issue 2142813003: bluetooth: Avoid including non-blink mojo bindings in blink code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/bluetooth/web_bluetooth_impl.h

Issue 2142813003: bluetooth: Avoid including non-blink mojo bindings in blink code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Go back to static cast Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/bluetooth/web_bluetooth_impl.h

diff --git a/content/renderer/bluetooth/web_bluetooth_impl.h b/content/renderer/bluetooth/web_bluetooth_impl.h

index 13d7c7b9a184704d660f643063075bedc227ddee..086266f74aa9954a73f7ce46e2a4f30532cc5caf 100644

--- a/content/renderer/bluetooth/web_bluetooth_impl.h

+++ b/content/renderer/bluetooth/web_bluetooth_impl.h

@@ -54,12 +54,12 @@ class CONTENT_EXPORT WebBluetoothImpl

void disconnect(const blink::WebString& device_id) override;

void getPrimaryServices(

const blink::WebString& device_id,

- blink::mojom::WebBluetoothGATTQueryQuantity quantity,

+ int32_t quantity,

Jeffrey Yasskin 2016/07/13 20:34:58 Could you comment what enum defines the values of

ortuno 2016/07/13 22:47:28 Done. What do you think?

const blink::WebString& services_uuid,

blink::WebBluetoothGetPrimaryServicesCallbacks* callbacks) override;

void getCharacteristics(

const blink::WebString& service_instance_id,

- blink::mojom::WebBluetoothGATTQueryQuantity quantity,

+ int32_t quantity,

const blink::WebString& characteristics_uuid,

blink::WebBluetoothGetCharacteristicsCallbacks* callbacks) override;

void readValue(const blink::WebString& characteristic_instance_id,

« no previous file with comments | « content/common/DEPS ('k') | content/renderer/bluetooth/web_bluetooth_impl.cc » ('j') | content/renderer/bluetooth/web_bluetooth_impl.cc » ('J')