Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 21428002: Add fetch recipe targeting iOS (Closed)

Created:
7 years, 4 months ago by stuartmorgan
Modified:
7 years, 4 months ago
Reviewers:
cmp, agable
CC:
chromium-reviews, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Add fetch recipe targeting iOS Adds support for passing target_os_only to the chromium recipe, and adds "fetch ios" as an alias for passing both target_os=['ios'] and target_os_only=True as described in the iOS build instructions page. BUG=None R=agable@chromium.org, cmp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215891

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M recipes/chromium.py View 1 chunk +2 lines, -0 lines 0 comments Download
A + recipes/ios.py View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
stuartmorgan
I figured out the issue right after asking (of course); I was missing the chromium.py ...
7 years, 4 months ago (2013-07-31 22:50:29 UTC) #1
agable
On 2013/07/31 22:50:29, stuartmorgan wrote: > I figured out the issue right after asking (of ...
7 years, 4 months ago (2013-07-31 22:57:39 UTC) #2
stuartmorgan
+cmp for OWNERS
7 years, 4 months ago (2013-07-31 23:07:22 UTC) #3
cmp
lgtm
7 years, 4 months ago (2013-08-02 23:58:40 UTC) #4
stuartmorgan
I'm getting "fatal: remote error: Git access forbidden" trying to push this. Do I need ...
7 years, 4 months ago (2013-08-05 22:58:48 UTC) #5
Dirk Pranke
On 2013/08/05 22:58:48, stuartmorgan wrote: > I'm getting "fatal: remote error: Git access forbidden" trying ...
7 years, 4 months ago (2013-08-05 23:01:05 UTC) #6
stuartmorgan
7 years, 4 months ago (2013-08-06 14:39:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r215891 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698