Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: components/webcrypto/webcrypto_impl.h

Issue 2142783002: Use std::unique_ptr to pass around WebCryptoDigestor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/webcrypto/webcrypto_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/webcrypto/webcrypto_impl.h
diff --git a/components/webcrypto/webcrypto_impl.h b/components/webcrypto/webcrypto_impl.h
index af5f6fcc3563c27cbff6ea88fce82e366b8346f1..b551213351ff01d4440f8d17cf6569a1f810f968 100644
--- a/components/webcrypto/webcrypto_impl.h
+++ b/components/webcrypto/webcrypto_impl.h
@@ -96,10 +96,8 @@ class WebCryptoImpl : public blink::WebCrypto {
// This method returns a digestor object that can be used to synchronously
// compute a digest one chunk at a time. Thus, the consume does not need to
// hold onto a large buffer with all the data to digest. Chunks can be given
- // one at a time and the digest will be computed piecemeal. The allocated
- // WebCrytpoDigestor that is returned by createDigestor must be freed by the
- // caller.
- blink::WebCryptoDigestor* createDigestor(
+ // one at a time and the digest will be computed piecemeal.
+ std::unique_ptr<blink::WebCryptoDigestor> createDigestor(
blink::WebCryptoAlgorithmId algorithm_id) override;
bool deserializeKeyForClone(const blink::WebCryptoKeyAlgorithm& algorithm,
« no previous file with comments | « no previous file | components/webcrypto/webcrypto_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698