Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2142773002: IDL: Add is_array and is_sequence properties (Closed)

Created:
4 years, 5 months ago by bashi
Modified:
4 years, 5 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IDL: Add is_array and is_sequence properties Though arrays are obsoleted and the code generator doesn't need to distinguish them, some analysis scripts may want to distinguish them. Committed: https://crrev.com/65ef444d589b6aef2e9a2960b37dfbb2ba0f953d Cr-Commit-Position: refs/heads/master@{#405400}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M third_party/WebKit/Source/bindings/scripts/idl_types.py View 4 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 20 (9 generated)
bashi
PTAL I have a script which needs to distinguish arrays and sequence so I'd like ...
4 years, 5 months ago (2016-07-12 04:51:51 UTC) #2
haraken
LGTM
4 years, 5 months ago (2016-07-12 04:57:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142773002/1
4 years, 5 months ago (2016-07-12 05:53:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/242317) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
4 years, 5 months ago (2016-07-12 06:19:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142773002/1
4 years, 5 months ago (2016-07-12 06:46:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191032)
4 years, 5 months ago (2016-07-12 08:08:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142773002/1
4 years, 5 months ago (2016-07-13 23:18:43 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/255464)
4 years, 5 months ago (2016-07-14 00:51:53 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142773002/1
4 years, 5 months ago (2016-07-14 00:56:00 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 02:00:14 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 02:01:54 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65ef444d589b6aef2e9a2960b37dfbb2ba0f953d
Cr-Commit-Position: refs/heads/master@{#405400}

Powered by Google App Engine
This is Rietveld 408576698