|
|
Chromium Code Reviews|
Created:
4 years, 5 months ago by bashi Modified:
4 years, 5 months ago Reviewers:
haraken CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionIDL: Add is_array and is_sequence properties
Though arrays are obsoleted and the code generator doesn't need to
distinguish them, some analysis scripts may want to distinguish them.
Committed: https://crrev.com/65ef444d589b6aef2e9a2960b37dfbb2ba0f953d
Cr-Commit-Position: refs/heads/master@{#405400}
Patch Set 1 #
Messages
Total messages: 20 (9 generated)
bashi@chromium.org changed reviewers: + haraken@chromium.org
PTAL I have a script which needs to distinguish arrays and sequence so I'd like to add this.
LGTM
The CQ bit was checked by bashi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by bashi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by bashi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by bashi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== IDL: Add is_array and is_sequence properties Though arrays are obsoleted and the code generator doesn't need to distinguish them, some analysis scripts may want to distinguish them. ========== to ========== IDL: Add is_array and is_sequence properties Though arrays are obsoleted and the code generator doesn't need to distinguish them, some analysis scripts may want to distinguish them. Committed: https://crrev.com/65ef444d589b6aef2e9a2960b37dfbb2ba0f953d Cr-Commit-Position: refs/heads/master@{#405400} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/65ef444d589b6aef2e9a2960b37dfbb2ba0f953d Cr-Commit-Position: refs/heads/master@{#405400} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
